[RFC] Added javawebstart.version property to netx

Man Wong mwong at redhat.com
Tue Jul 20 13:58:20 PDT 2010


Pushed as changesets 

-2489bca2d112 for 1.8
-ce09ca575fdb for 1.7
-7a124a6f0568 and 4bcc2702e0ec for head (there are 2 because of minor formatting mistakes
made in the Changelog, which was fixed in 7a124a6f0568).

Thanks,
Man Lung Wong
 
----- "Deepak Bhole" <dbhole at redhat.com> wrote:

> * Man Wong <mwong at redhat.com> [2010-07-20 13:24]:
> > The attached patch adds javawebstart.version as a system property
> whenever a 
> > jnlp file is being launched. It also gives the user the permission
> to read that 
> > property when working under sandbox permission. This fixes icedtea
> bug 486.
> > Even though bug 486 says there is a problem with the encoding
> support. However,
> > after add the encoding support, the file could not be launched
> because the
> > above permission was denied. 
> > 
> > Should I file a separate bug for the permission issue, or can I just
> mention
> > that as part of bug 486?
> > 
> > Any comments?
> > 
> > Thanks,
> > Man Lung Wong
> 
> Looks good. Please commit to 1.7 and 1.8 along with HEAD.
> 
> Cheers,
> Deepak
> 
> > diff -r 16b019555725 netx/net/sourceforge/jnlp/SecurityDesc.java
> > --- a/netx/net/sourceforge/jnlp/SecurityDesc.java	Tue Jul 20
> 09:35:12 2010 -0400
> > +++ b/netx/net/sourceforge/jnlp/SecurityDesc.java	Tue Jul 20
> 11:11:05 2010 -0400
> > @@ -94,6 +94,7 @@
> >          new PropertyPermission("java.vm.version", "read"),
> >          new PropertyPermission("java.vm.vendor", "read"),
> >          new PropertyPermission("java.vm.name", "read"),
> > +        new PropertyPermission("javawebstart.version", "read"),
> >          new RuntimePermission("exitVM"),
> >          new RuntimePermission("stopThread"),
> >          new AWTPermission("showWindowWithoutWarningBanner"),
> > diff -r 16b019555725
> netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java
> > --- a/netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java	Tue Jul 20
> 09:35:12 2010 -0400
> > +++ b/netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java	Tue Jul 20
> 11:11:05 2010 -0400
> > @@ -167,6 +167,11 @@
> >          checkInitialized();
> >       
> >          isWebstartApplication = isApplication;
> > +        
> > +        //Setting the system property for javawebstart's version.
> > +        //The version stored will be the same as java's version.
> > +        System.setProperty("javawebstart.version", "javaws-" +
> > +            System.getProperty("java.version"));
> >  
> >          if (headless == false)
> >              checkHeadless();



More information about the distro-pkg-dev mailing list