[RFC] netx: stop using Look and Feel related methods (PR372)

[Dr Andrew John Hughes]

On 16 July 2010 21:40, Deepak Bhole <dbhole at redhat.com> wrote:
> * Omair Majid <omajid at redhat.com> [2010-07-06 11:29]:
>> Hi,
>>
>> Netx (incorrectly) uses Look and Feel related hooks and methods to
>> create the security-related dialogs it shows to the user [1]. While
>> most of the time it has no consequences, a few JNLP applications
>> that modify the Look and Feel demonstrate incorrect behaviour [2].
>> The attached patch uses the standard Swing methods to create and
>> display GUIs. It is a somewhat large patch, even though most of it
>> is fairly mundane - creating JDialogs, setting a JPanel in the
>> center depending on the type of dialog and then adding the
>> appropriate controls to the JPanel. I have tried to avoid changing
>> anything that goes inside the JPanel - it should behave exactly as
>> before. I have done some testing and it seems to work just as well
>> as before, but I would appreciate it if others could look it over
>> and try it out too.
>>
>> Cheers,
>> Omair
>>
>> [1] http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=372
>> [2] https://substance.dev.java.net/webstart/test.jnlp
>
> Doh! I thought I went through this one when I approved the rest.
>
> A lot of these changes do look mechanical as you stated.
>
> I am fine with committing this to head, but please make sure you have
> THOROUGHLY tested this.. breakages in things like security dialog would
> make netx/plugin unusable for signed applications, so we need to make
> sure it works well.
>
> Cheers,
> Deepak
>

With this in mind, please do not backport this patch.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8