/hg/icedtea6: Backpatch fix for upstream bug#6963870 from jdk7 t...

[vanaltj at icedtea.classpath.org]

changeset 6bf6ff2ad1ea in /hg/icedtea6
details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=6bf6ff2ad1ea
author: Jon VanAlten <jon.vanalten at redhat.com>
date: Fri Jul 23 11:51:57 2010 -0400

	Backpatch fix for upstream bug#6963870 from jdk7 to eliminate
	NullPointerEx in swing class CompoundBorder method getBorderInsets

	 * patches/openjdk/6963870.patch: New file. Backpatched from
	jdk7 for upstream bug#6963870. Fixes IcedTea Bug#477:
	NullPointerEx in swing class CompoundBorder method
	getBorderInsets.
		* Makefile.am: Include above patch.


diffstat:

3 files changed, 99 insertions(+), 1 deletion(-)
ChangeLog                     |    7 +++
Makefile.am                   |    3 -
patches/openjdk/6963870.patch |   90 +++++++++++++++++++++++++++++++++++++++++

diffs (121 lines):

diff -r 7e8348b468ae -r 6bf6ff2ad1ea ChangeLog
--- a/ChangeLog	Fri Jul 23 10:56:39 2010 +0100
+++ b/ChangeLog	Fri Jul 23 11:51:57 2010 -0400
@@ -1,3 +1,10 @@ 2010-07-23  Andrew John Hughes  <ahughes
+2010-07-23  Jon VanAlten  <jon.vanalten at redhat.com>
+
+	* patches/openjdk/6963870.patch: New file. Backpatched from jdk7 for
+	upstream bug#6963870. Fixes IcedTea Bug#477: NullPointerEx in swing
+	class CompoundBorder method getBorderInsets.
+	* Makefile.am: Include above patch.
+
 2010-07-23  Andrew John Hughes  <ahughes at redhat.com>
 
 	* netx/net/sourceforge/jnlp/security/AccessWarningPane.java:
diff -r 7e8348b468ae -r 6bf6ff2ad1ea Makefile.am
--- a/Makefile.am	Fri Jul 23 10:56:39 2010 +0100
+++ b/Makefile.am	Fri Jul 23 11:51:57 2010 -0400
@@ -282,7 +282,8 @@ ICEDTEA_PATCHES = \
 	patches/openjdk/6961732.patch \
 	patches/debug-dir.patch \
 	patches/no-sync.patch \
-	patches/icedtea-override-redirect-metacity.patch
+	patches/icedtea-override-redirect-metacity.patch \
+	patches/openjdk/6963870.patch
 
 if WITH_RHINO
 ICEDTEA_PATCHES += \
diff -r 7e8348b468ae -r 6bf6ff2ad1ea patches/openjdk/6963870.patch
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/patches/openjdk/6963870.patch	Fri Jul 23 11:51:57 2010 -0400
@@ -0,0 +1,90 @@
+diff -r a05e047c5b98 -r f1bafc4f249d src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java
+--- openjdk.old/jdk/src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java	Tue Jun 22 20:36:55 2010 +0400
++++ openjdk/jdk/src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java	Tue Jun 29 14:42:30 2010 +0400
+@@ -1440,10 +1440,6 @@
+             }
+         }
+ 
+-        public Insets getBorderInsets(Component c) {
+-            return getBorderInsets(c, null);
+-        }
+-
+         public Insets getBorderInsets(Component c, Insets i) {
+             SynthContext context = getContext(c);
+ 
+diff -r a05e047c5b98 -r f1bafc4f249d test/com/sun/java/swing/plaf/gtk/Test6963870.java
+--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
++++ openjdk/jdk/test/com/sun/java/swing/plaf/gtk/Test6963870.java	Tue Jun 29 14:42:30 2010 +0400
+@@ -0,0 +1,72 @@
++/*
++ * Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved.
++ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
++ *
++ * This code is free software; you can redistribute it and/or modify it
++ * under the terms of the GNU General Public License version 2 only, as
++ * published by the Free Software Foundation.
++ *
++ * This code is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
++ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
++ * version 2 for more details (a copy is included in the LICENSE file that
++ * accompanied this code).
++ *
++ * You should have received a copy of the GNU General Public License version
++ * 2 along with this work; if not, write to the Free Software Foundation,
++ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
++ *
++ * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
++ * CA 95054 USA or visit www.sun.com if you need additional information or
++ * have any questions.
++ */
++
++/* @test
++   @bug 6963870
++   @summary Tests that GTKPainter.ListTableFocusBorder.getBorderInsets()
++            doesn't return null
++   @author Peter Zhelezniakov
++   @run main Test6963870
++*/
++
++import java.awt.Insets;
++import javax.swing.SwingUtilities;
++import javax.swing.UIManager;
++import javax.swing.border.Border;
++
++public class Test6963870 implements Runnable {
++
++    final static String[] UI_NAMES = {
++        "List.focusCellHighlightBorder",
++        "List.focusSelectedCellHighlightBorder",
++        "List.noFocusBorder",
++        "Table.focusCellHighlightBorder",
++        "Table.focusSelectedCellHighlightBorder",
++    };
++
++    public void run() {
++        for (String uiName: UI_NAMES) {
++            test(uiName);
++        }
++    }
++
++    void test(String uiName) {
++        Border b = UIManager.getBorder(uiName);
++        Insets i = b.getBorderInsets(null);
++        if (i == null) {
++            throw new RuntimeException("getBorderInsets() returns null for " + uiName);
++        }
++    }
++
++    public static void main(String[] args) throws Exception {
++        try {
++            UIManager.setLookAndFeel("com.sun.java.swing.plaf.gtk.GTKLookAndFeel");
++        } catch (Exception e) {
++            System.out.println("GTKLookAndFeel cannot be set, skipping this test");
++            return;
++        }
++
++        SwingUtilities.invokeAndWait(new Test6963870());
++    }
++}
++