[RFC] Updated: Systemtap tapset test suite.

[jon.vanalten at redhat.com]

Hi,

Some time back I posted a version of this, got some feedback, addressed the feedback, with the end result appearing here[1].  I've since updated the Makefile.am target to reflect changes to build directories, and fixed a couple of correctness issues (doh!  noob mistake, wasn't zeroing some memory before writing strings into it; not sure why this wasn't causing me problems before).  It would be great to get this committed.  This would catch issues before they go out the door[2][3].  I have two questions before I commit (if people think this is okay).  Right now the jstaptest.pl script returns a failure condition if any tests fail, which Make then of course detects and stops.  Is this the right approach, or should the script simply return OK all the time?  Also, right now the tapsetcheck target is a dependency for make check, does anyone have a problem with this test being run automatically?

[1] http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-March/008808.html
[2] https://bugzilla.redhat.com/show_bug.cgi?id=613822
[3] http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=527

thanks,

jon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: staptest.patch
Type: text/x-patch
Size: 174255 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20100729/adadcd88/staptest.patch