[RFC] netx: minor fixes to XJNLPRandomAccessFile

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2010-07-29 15:48]:
> Hi,
> 
> The attached patch makes the JNLPRandomAccessFile interface extend
> java.io.DataInput and java.io.DataOutput as stated in the
> Javadocs[1]. It also makes the constructor throw IOExceptions
> instead of swallowing them (the constructor is only called from
> XFileContents.getRandomAccessFile() which declares that it can throw
> IOExceptions).
> 
> Any objections to committing the patch?
> 

OK to commit to HEAD.

Cheers,
Deepak

> Cheers,
> Omair
> 
> [1] http://download-llnw.oracle.com/javase/1.5.0/docs/guide/javaws/jnlp/javax/jnlp/JNLPRandomAccessFile.html

> diff -r 41911a183c51 netx/javax/jnlp/JNLPRandomAccessFile.java
> --- a/netx/javax/jnlp/JNLPRandomAccessFile.java	Thu Jul 29 14:06:38 2010 +0200
> +++ b/netx/javax/jnlp/JNLPRandomAccessFile.java	Thu Jul 29 10:03:41 2010 -0400
> @@ -1,8 +1,8 @@
>  
>  
>  package javax.jnlp;
> +public interface JNLPRandomAccessFile extends java.io.DataInput, java.io.DataOutput {
>  
> -public interface JNLPRandomAccessFile {
>  
>    public void close() throws java.io.IOException;
>    public long length() throws java.io.IOException;
> diff -r 41911a183c51 netx/net/sourceforge/jnlp/services/XJNLPRandomAccessFile.java
> --- a/netx/net/sourceforge/jnlp/services/XJNLPRandomAccessFile.java	Thu Jul 29 14:06:38 2010 +0200
> +++ b/netx/net/sourceforge/jnlp/services/XJNLPRandomAccessFile.java	Thu Jul 29 10:03:41 2010 -0400
> @@ -37,7 +37,6 @@
>  package net.sourceforge.jnlp.services;
>  
>  import java.io.File;
> -import java.io.FileNotFoundException;
>  import java.io.IOException;
>  import java.io.RandomAccessFile;
>  
> @@ -47,13 +46,9 @@
>  
>          private RandomAccessFile raf;
>  
> -        public XJNLPRandomAccessFile(File file, String mode) {
> -                try {
> -                        raf = new RandomAccessFile(file, mode);
> -                } catch (FileNotFoundException e) {
> -                        // TODO Auto-generated catch block
> -                        e.printStackTrace();
> -                }
> +        public XJNLPRandomAccessFile(File file, String mode) throws IOException {
> +                raf = new RandomAccessFile(file, mode);
> +
>          }
>  
>          public void close() throws IOException {