[RFC] netx: fix missing space that causes showDocuement(URL) to fail

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2010-07-20 14:40]:
> Hi,
> 
> Netx provides a way to open a URL in the web browser using
> XBasicService.showDocument(URL). Currently it fails to work because
> of a missing space between the browser command (eg:
> /usr/bin/firefox) and the URL (eg: www.google.ca). The attached
> patch attempts to fix this.
> 
> The problem can be replicated with the program at [1] which does
> nothing when you enter a url and press enter. Running with -verbose
> shows:
> 
> call privileged method: showDocument
>            arg: http://www.google.ca
> java.io.IOException: Cannot run program
> "/usr/bin/firefoxhttp://www.google.ca": java.io.IOException:
> error=2, No such file or directory.
> 
> Any objections to committing this?
> 
> Cheers,
> Omair
> 

OK to commit to HEAD, 1.6, 1.7 and 1.8.

Cheers,
Deepak

> [1] http://pscode.org/jws/basicserv.jnlp

> diff -r b110028e95cc netx/net/sourceforge/jnlp/services/XBasicService.java
> --- a/netx/net/sourceforge/jnlp/services/XBasicService.java	Tue Jul 20 13:39:49 2010 -0400
> +++ b/netx/net/sourceforge/jnlp/services/XBasicService.java	Tue Jul 20 14:27:36 2010 -0400
> @@ -176,7 +176,7 @@
>                  // this is bogus because the command may require options;
>                  // should use a StreamTokenizer or similar to get tokens
>                  // outside of quotes.
> -                Runtime.getRuntime().exec(command + url.toString());
> +                Runtime.getRuntime().exec(command + " " + url.toString());
>                  //Runtime.getRuntime().exec(new String[]{command,url.toString()});
>  
>                  return true;