The big Zero deletion

Gary Benson gbenson at redhat.com
Fri Jun 18 02:46:55 PDT 2010


Andrew John Hughes wrote:
> Ok the IcedTea6 local changes actually break the build:
> 
> /mnt/builder/icedtea6-hg/openjdk/hotspot/src/share/vm/runtime/globals.hpp:50:1:
> error: redefinition of 'const intx pd_InlineSmallCode'
> /mnt/builder/icedtea6-hg/openjdk/hotspot/src/cpu/zero/vm/globals_zero.hpp:49:1:
> error: 'const intx pd_InlineSmallCode' previously defined here
> 
> I presume they were added for hs14, when we're now on hs17.  I'm
> dropping these changes.

Awesome.  I was trying to figure out why they would be necessary, but
I guess that's why :)

> > > > ports/hotspot/src/./cpu/zero/vm/disassembler_zero.hpp:
[snip]
> > > This change is being upstreamed as part of Shark.  It's probably
> > > best to simply ignore this one and just use whatever comes from
> > > upstream.  It's only for a not-very-useful debug option that
> > > probably nobody even knows about.
> >
> > Ok, do you have this somewhere else if we delete it from IcedTea6?
> 
> I think I'll leave this in, but convert it to a patch
> (shark-debug-option.patch)

I do have it elsewhere (in the Shark repo) but a patch is good too.

Cheers,
Gary

--
http://gbenson.net/



More information about the distro-pkg-dev mailing list