[RFC] Netx: clean up path sanitization code
Andrew John Hughes
ahughes at redhat.com
Thu Jun 24 16:37:10 PDT 2010
On 24 June 2010 17:04, Omair Majid <omajid at redhat.com> wrote:
> Hi,
>
> The attached patch does a little bit of refactoring, moving path
> manipulation functions to a common location.
>
> Any comments?
>
> Cheers,
> Omair
>
Looks good. It's more than just cleanup though, as the behaviour of
sanitizeFileName has changed. It now only replaces ILLEGAL_CHARS and
not all characters that aren't in the legal set.
I'd also make the two arrays private and final.
Cheers,
--
Andrew :-)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the distro-pkg-dev
mailing list