[NEW RFC] Re: RFC: Test set for systemtap instrumentation

[jon.vanalten at redhat.com]

As promised, updated patch for review.

----- "Andrew John Hughes" <gnu_andrew at member.fsf.org> wrote:

> On 3 March 2010 17:08,  <jon.vanalten at redhat.com> wrote:
> >
> > ----- "Andrew John Hughes" <gnu_andrew at member.fsf.org> wrote:
> >> Assuming it can be automated, it needs a check-systemtap target
> which
> >> check-local depends on and whose body is inside an if
> >> ENABLE_SYSTEMTAP.

Done.  Test also produces a log which is removed by a dependency on distclean-local.

> >>The script seems to have hardcoded locations:
> >>
> >> +JAVA_EXEC="java"
> >> +JAVAC_EXEC="javac"
> >>
> +JVM_DIR="/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/jre/lib/amd64/server/"
> >> +JVM_SO="-ljvm"
> >>
> +INCLUDE_DIR="-I/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/include/
> >> -I/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/include/linux/"
> >>
> >> These are only likely to work on x86_64 Fedora boxes.  The script
> >> should take the JAVA_HOME as an argument and calculate the paths
> from
> >> this.  The Makefile can pass the location of the just-built
> IcedTea
> >> to
> >> the script.
> >>

These concerns are addressed by changes made while rewriting wrapper script in Perl.  There are now two distinct modes of running the tests.  One takes $(abs_top_builddir)/$(BUILD_OUTPUT_DIR) and $(BUILD_ARCH_DIR) to test a local build of icedtea.  Makefile integration obviously uses this mode.  The other takes just the location of an installed icedtea/openjdk and detects the system arch to determine certain subdirs.  So no more hardcoded paths, and things should be arch-happy, for all supported arch.

Comments?  Concerns?  OK to commit?


cheers,

jon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: staptest.patch
Type: text/x-patch
Size: 163062 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20100305/47392119/staptest.patch