/hg/icedtea6: Backport fix for Sun bug 6822370.

[andrew at icedtea.classpath.org]

changeset aec804768b19 in /hg/icedtea6
details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=aec804768b19
author: Andrew John Hughes <ahughes at redhat.com>
date: Wed Mar 10 21:53:48 2010 +0000

	Backport fix for Sun bug 6822370.

	2010-03-10 Andrew John Hughes <ahughes at redhat.com>

	 * Makefile.am: Add new patch.
		* patches/openjdk/6822370-reentrantreadwritelock.patch:
	Backported patch from HotSpot 16 to fix bug S6822370;
	threads blocked when the ReentrantReadWriteLock is not held.


diffstat:

3 files changed, 77 insertions(+), 2 deletions(-)
ChangeLog                                            |   11 ++-
Makefile.am                                          |    3 
patches/openjdk/6822370-reentrantreadwritelock.patch |   65 ++++++++++++++++++

diffs (100 lines):

diff -r 5d383d2ad0e5 -r aec804768b19 ChangeLog
--- a/ChangeLog	Wed Mar 10 19:25:51 2010 +0000
+++ b/ChangeLog	Wed Mar 10 21:53:48 2010 +0000
@@ -1,4 +1,13 @@ 2010-03-08  Andrew John Hughes  <ahughes
-2010-03-08  Andrew John Hughes  <ahughes at redhat.com>
+2010-03-10  Andrew John Hughes  <ahughes at redhat.com>
+
+	* Makefile.am:
+	Add new patch.
+	* patches/openjdk/6822370-reentrantreadwritelock.patch:
+	Backported patch from HotSpot 16 to fix bug S6822370;
+	threads blocked when the ReentrantReadWriteLock is
+	not held.
+
+2010-03-10  Andrew John Hughes  <ahughes at redhat.com>
 
 	* Makefile.am:
 	(JAXP): Removed, redundant.
diff -r 5d383d2ad0e5 -r aec804768b19 Makefile.am
--- a/Makefile.am	Wed Mar 10 19:25:51 2010 +0000
+++ b/Makefile.am	Wed Mar 10 21:53:48 2010 +0000
@@ -367,7 +367,8 @@ ICEDTEA_PATCHES += patches/hotspot/origi
 ICEDTEA_PATCHES += patches/hotspot/original/icedtea-6778662-lib64.patch \
 	patches/hotspot/original/icedtea-6778657-f2i-overflow.patch \
 	patches/hotspot/original/icedtea-6791168.patch \
-	patches/hotspot/original/icedtea-6793825-includedb.patch
+	patches/hotspot/original/icedtea-6793825-includedb.patch \
+	patches/openjdk/6822370-reentrantreadwritelock.patch
 endif
 
 ICEDTEA_PATCHES += patches/icedtea-override.patch
diff -r 5d383d2ad0e5 -r aec804768b19 patches/openjdk/6822370-reentrantreadwritelock.patch
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/patches/openjdk/6822370-reentrantreadwritelock.patch	Wed Mar 10 21:53:48 2010 +0000
@@ -0,0 +1,65 @@
+# HG changeset patch
+# User dholmes
+# Date 1259712624 18000
+# Node ID 49bd3de668dc35ba7cff876422d114a91f35bbd2
+# Parent  b6e6e189e1db90e044c24be709bc581e2356a910
+6822370: ReentrantReadWriteLock: threads hung when there are no threads holding onto the lock (Netra x4450)
+Summary: This day one bug is caused by missing memory barriers in various Parker::park() paths that can result in lost wakeups and hangs.
+Reviewed-by: dice, acorn
+
+diff -r b6e6e189e1db -r 49bd3de668dc src/os/linux/vm/os_linux.cpp
+--- openjdk.orig/hotspot/src/os/linux/vm/os_linux.cpp	Wed Nov 25 19:15:17 2009 -0800
++++ openjdk/hotspot/src/os/linux/vm/os_linux.cpp	Tue Dec 01 19:10:24 2009 -0500
+@@ -4656,6 +4656,7 @@
+   // Return immediately if a permit is available.
+   if (_counter > 0) {
+       _counter = 0 ;
++      OrderAccess::fence();
+       return ;
+   }
+ 
+@@ -4698,6 +4699,7 @@
+     _counter = 0;
+     status = pthread_mutex_unlock(_mutex);
+     assert (status == 0, "invariant") ;
++    OrderAccess::fence();
+     return;
+   }
+ 
+@@ -4737,7 +4739,7 @@
+   if (jt->handle_special_suspend_equivalent_condition()) {
+     jt->java_suspend_self();
+   }
+-
++  OrderAccess::fence();
+ }
+ 
+ void Parker::unpark() {
+diff -r b6e6e189e1db -r 49bd3de668dc src/os/solaris/vm/os_solaris.cpp
+--- openjdk.orig/hotspot/src/os/solaris/vm/os_solaris.cpp	Wed Nov 25 19:15:17 2009 -0800
++++ openjdk/hotspot/src/os/solaris/vm/os_solaris.cpp	Tue Dec 01 19:10:24 2009 -0500
+@@ -5803,6 +5803,7 @@
+   // Return immediately if a permit is available.
+   if (_counter > 0) {
+       _counter = 0 ;
++      OrderAccess::fence();
+       return ;
+   }
+ 
+@@ -5846,6 +5847,7 @@
+     _counter = 0;
+     status = os::Solaris::mutex_unlock(_mutex);
+     assert (status == 0, "invariant") ;
++    OrderAccess::fence();
+     return;
+   }
+ 
+@@ -5891,7 +5893,7 @@
+   if (jt->handle_special_suspend_equivalent_condition()) {
+     jt->java_suspend_self();
+   }
+-
++  OrderAccess::fence();
+ }
+ 
+ void Parker::unpark() {