[rfc] new configure option --enable-debug-mode

[Deepak Bhole]

* Matthias Klose <doko at ubuntu.com> [2010-03-31 06:32]:
> Triggered by
> https://bugzilla.mozilla.org/show_bug.cgi?id=555342
> 
> Proposing a new configure option --enable-debug-mode. The option
> makes it possible to entirely disable the debug code, not allowing
> to open a socket. The default for prereleases/trunk is to have it
> enabled, for releases disabled.
> 

Why would you want to disable debug mode? It is not intended to be run
unless a problem is being diagnosed... normal users would never had an
issue with it..

And if this is to be done, it should certainly not disable all debug.
Debug output is very useful to look at when an end user is having an
issue.

Cheers,
Deepak

> 2010-03-31  Matthias Klose  <doko at ubuntu.com>
> 
> 	    * acinclude.m4 (IT_CHECK_PLUGIN): New option
> 	    --enable-plugin-debug-mode.
> 	    * Makefile.am ($(PLUGIN_DIR)/%.o): Pass PLUGIN_DEBUG_CFLAGS.
> 	    * plugin/icedteanp/IcedTeaNPPlugin.cc (plugin_debug): Initialize
> 	    depending on PLUGIN_DEBUG_MODE.
> 
> diff -r 0ff8bd7adb9c Makefile.am
> --- a/Makefile.am	Wed Mar 31 10:32:12 2010 +0200
> +++ b/Makefile.am	Wed Mar 31 11:58:26 2010 +0200
> @@ -1532,6 +1532,7 @@
>  	  -DJDK_UPDATE_VERSION="\"$(JDK_UPDATE_VERSION)\"" \
>  	  -DPLUGIN_VERSION="\"$(PLUGIN_VERSION)\"" \
>  	  -DMOZILLA_VERSION_COLLAPSED="$(MOZILLA_VERSION_COLLAPSED)" \
> +	  $(PLUGIN_DEBUG_CFLAGS) \
>  	  $(GLIB_CFLAGS) \
>  	  $(GTK_CFLAGS) \
>  	  $(MOZILLA_CFLAGS) \
> diff -r 0ff8bd7adb9c acinclude.m4
> --- a/acinclude.m4	Wed Mar 31 10:32:12 2010 +0200
> +++ b/acinclude.m4	Wed Mar 31 11:58:26 2010 +0200
> @@ -1446,6 +1446,27 @@
>                                [Disable compilation of browser plugin])],
>                [enable_plugin="${enableval}"], [enable_plugin="yes"])
>  AC_MSG_RESULT(${enable_plugin})
> +
> +AC_MSG_CHECKING([whether to enable the plugin debug mode])
> +AC_ARG_ENABLE([plugin-debug-mode],
> +              [AS_HELP_STRING([--enable-plugin-debug-mode],
> +                              [Enable the plugin debug mode])
> +],[
> +  enable_plugin_debug_mode="${enableval}"
> +],[
> +  case "$PACKAGE_VERSION" in
> +    *pre*) enable_plugin_debug_mode="yes";;
> +    *)     enable_plugin_debug_mode="no";;
> +  esac
> +])
> +if test x${enable_plugin} != xyes ; then
> +  enable_plugin_debug_mode="no"
> +fi
> +AC_MSG_RESULT(${enable_plugin_debug_mode})
> +if test x${enable_plugin_debug_mode} = xyes ; then
> +  PLUGIN_DEBUG_CFLAGS="-DPLUGIN_DEBUG_MODE=1"
> +fi
> +AC_SUBST(PLUGIN_DEBUG_CFLAGS)
>  ])
>  
>  AC_DEFUN_ONCE([IT_CHECK_PLUGIN_DEPENDENCIES],
> diff -r 0ff8bd7adb9c plugin/icedteanp/IcedTeaNPPlugin.cc
> --- a/plugin/icedteanp/IcedTeaNPPlugin.cc	Wed Mar 31 10:32:12 2010 +0200
> +++ b/plugin/icedteanp/IcedTeaNPPlugin.cc	Wed Mar 31 11:58:26 2010 +0200
> @@ -234,7 +234,11 @@
>  static GPid appletviewer_pid = -1;
>  static guint appletviewer_watch_id = -1;
>  
> +#ifdef PLUGIN_DEBUG_MODE
>  int plugin_debug = getenv ("ICEDTEAPLUGIN_DEBUG") != NULL;
> +#else
> +int plugin_debug = 0;
> +#endif
>  
>  pthread_cond_t cond_message_available = PTHREAD_COND_INITIALIZER;
>