[RFC] PulseAudio bugfix

[jon.vanalten at redhat.com]

Hi,

The attached diff fixes:
http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=438

Comparing the class of the Control.Type to determine support is completely wrong.  It returns true when it should return true, but it gives false positives for most cases that should return false.  The known Types are static instances, so comparing them using .equals() should give correct results.  I've confirmed that passing a Control whose Type the PulseAudio provider does not support now returns false, while a Control that is supported returns true.  (Only FloatControl.Type.VOLUME is currently supported).

I also took the liberty of making sure the PulseAudio source files are added to src.zip when building with --enable-pulseaudio.  In the past, the sources were bundled into the pulseaudio.jar, which was far from ideal for filesize reasons.  This practice was ended with:
http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=b9c4bedba90e
However, now the jdk image does not have those sources anywhere, which is a problem for anyone looking to debug sound using the pulseaudio provider.  I didn't see a good way to force the openjdk to add the files when initially creating the zip; the contents are determined in openjdk/jdk/make/common/Release.gmk.  So I just add them in afterwards.

Any comments?  If these look okay, I assume the changes should be applied to both icedtea6 and icedtea.

cheers,

jon


P.S.  As an afterthought, which might change how this is handled, is there a way for the contents of a patch in icedtea to be changed based on paths determined at ./configure time?  If so I can patch Release.gmk mentioned above instead of this .zip update process which feels a little hackish.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: iscontrolsupported.diff
Type: text/x-patch
Size: 1144 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20100503/07d1cbe7/iscontrolsupported.diff