New calling convention for Zero and Shark
Gary Benson
gbenson at redhat.com
Fri May 14 06:39:15 PDT 2010
Andrew John Hughes wrote:
> On 14 May 2010 14:05, Gary Benson <gbenson at redhat.com> wrote:
> > This commit fixes PR icedtea/484, a bug where the native code for
> > deoptimized methods could be freed when in fact they were still on
> > the stack and waiting to return.
> >
> > To make this change I have had to change the calling convention
> > within Zero and Shark. All method entries (the C function that
> > executes the method) now return an integer which is the number
> > of deoptimized frames they have left on the stack. Whenever a
> > method is called it is now the caller's responsibility to check
> > whether frames have been deoptimized and reenter the interpreter
> > if they have.
> >
> > The ARM interpreter needs updating to follow the new convention.
> > I have made a note of this in zeroshark.make, where the code that
> > enables the ARM interpreter is currently commented out.
>
> These descriptions are very useful, but could you include them as
> part of the commit message? They'll still get e-mailed out (as part
> of the commit) and we then have the description in Mercurial with
> the patch, rather than having to look it up in the mailing list
> archives for each patch.
Ok.
Cheers,
Gary
--
http://gbenson.net/
More information about the distro-pkg-dev
mailing list