Regression test for non-Latin character rendering
Dr Andrew John Hughes
ahughes at redhat.com
Mon Nov 1 06:18:43 PDT 2010
On 13:03 Mon 01 Nov , Pavel Tisnovsky wrote:
> Pavel Tisnovsky wrote:
> > Hi all,
> >
> > I created regression test (reproducer) for RH bug
> > https://bugzilla.redhat.com/show_bug.cgi?id=643674
> >
> > This regression test checks if all required fonts are properly installed
> > and that *.src.properties font configuration file is correct for given
> > system (Debian, Fedora, Ubuntu, SuSE...). The test is based on rendering
> > certain characters from selected code pages into BufferedImage.
> >
> > When the required font does not exists or font configuration is broken
> > in any way, only empty rectangle is rendered instead of the selected
> > character shape. This rectangle is filtered and then the destination
> > image is tested whether it is empty or almost empty (ie if it contains
> > only white area). White area means that selected character is not
> > correctly rendered and vice versa.
> >
> > If test images with rendered characters needs to be created, please use
> > the following flag:
> >
> > -create-images
> >
> > (name of each image start with character code)
> >
> > Is it ok to push this test (as patch) to IcedTea6 HEAD?
> >
> > (I'd like to push it to OpenJDK6 & OpenJDK7, but it takes some time to
> > get approved...)
> >
> > Cheers,
> > Pavel
> >
>
> Hi,
>
> I would also like to add one thing: diffstat for IcedTea6 HEAD is stored
> in attachment (in hg export format).
>
Does this run ok with a normal check-jdk JTreg run?
If so, please commit.
> Cheers,
> Pavel
> # HG changeset patch
> # User ptisnovs
> # Date 1288609100 -3600
> # Node ID 9e93fe87fc3a9bf337d556d65438032e0cd85359
> # Parent 0bfb4898c03918836c6fd811d8a373a68d69ed6c
> Added new regression test for checking if all non-Latin fonts are installed and properly configured..
>
> diff -r 0bfb4898c039 -r 9e93fe87fc3a ChangeLog
> --- a/ChangeLog Wed Oct 20 14:45:55 2010 +0100
> +++ b/ChangeLog Mon Nov 01 11:58:20 2010 +0100
> @@ -1,3 +1,12 @@
> +2010-11-01 Pavel Tisnovsky <ptisnovs at redhat.com>
> +
> + * Makefile.am:
> + * patches/icedtea-jtreg-international-fonts.patch:
> + Added new regression test
> + patches/icedtea-jtreg-international-fonts.patch
> + for checking if all non-Latin fonts are installed
> + and properly configured.
> +
> 2010-10-19 Andrew John Hughes <ahughes at redhat.com>
>
> * INSTALL: Clarify HotSpot build documentation.
> diff -r 0bfb4898c039 -r 9e93fe87fc3a Makefile.am
> --- a/Makefile.am Wed Oct 20 14:45:55 2010 +0100
> +++ b/Makefile.am Mon Nov 01 11:58:20 2010 +0100
> @@ -291,8 +291,9 @@
> patches/numa_on_early_glibc.patch \
> patches/icedtea-shark-build.patch \
> patches/openjdk/6985992-test_6933784.patch \
> - patches/openjdk/6853592-badwindow-warning-fix.patch \
> - patches/6703377-freetypescaler.patch
> + patches/openjdk/6853592-badwindow-warning-fix.patch \
> + patches/6703377-freetypescaler.patch \
> + patches/icedtea-jtreg-international-fonts.patch
>
> if !WITH_ALT_HSBUILD
> ICEDTEA_PATCHES += \
> diff -r 0bfb4898c039 -r 9e93fe87fc3a patches/icedtea-jtreg-international-fonts.patch
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/patches/icedtea-jtreg-international-fonts.patch Mon Nov 01 11:58:20 2010 +0100
> @@ -0,0 +1,195 @@
> +--- /dev/null 2010-06-29 14:56:30.329576932 +0200
> ++++ openjdk/jdk/test/java/awt/font/InternationalFonts/InternationalFontsRendering.java 2010-11-01 11:27:46.000000000 +0100
> +@@ -0,0 +1,192 @@
> ++import java.awt.Color;
> ++import java.awt.Font;
> ++import java.awt.Graphics2D;
> ++import java.awt.RenderingHints;
> ++import java.awt.image.BufferedImage;
> ++import java.io.File;
> ++import java.io.IOException;
> ++import java.util.Arrays;
> ++import java.util.List;
> ++import java.util.ArrayList;
> ++
> ++import javax.imageio.ImageIO;
> ++
> ++/**
> ++ * @test
> ++ * @run main InternationalFontsRendering
> ++ * @author Pavel Tisnovsky
> ++ *
> ++ * @summary This test check if all required fonts are properly installed and configured.
> ++ *
> ++ * This regression test checks if all required fonts are properly installed and
> ++ * that .src.properties font configuration is correct. The test is based on
> ++ * rendering certain characters from selected code pages into BufferedImage.
> ++ *
> ++ * When the font does not exists or font configuration is broken, only empty
> ++ * rectangle is rendered instead of the selected character shape. This rectangle
> ++ * is filtered and then the destination image is tested whether it is empty
> ++ * (=white).
> ++ *
> ++ * If test images with rendered characters needs to be created use following flag:
> ++ * -create-images
> ++ *
> ++ * regression for bug: https://bugzilla.redhat.com/show_bug.cgi?id=643674
> ++ * (Bug 643674 Misconfigured Path for Asian Font)
> ++ *
> ++ */
> ++public class InternationalFontsRendering
> ++{
> ++ private static int WIDTH = 200;
> ++ private static int HEIGHT = 200;
> ++
> ++ private static final int FONT_SIZE = 160;
> ++
> ++ private static final int MINIMUM_HORIZONTAL_LINE_LENGTH = 70;
> ++ private static final int MINIMUM_VERTICAL_LINE_LENGTH = 80;
> ++ private static final int BLACK_WHITE_THRESHOLD = 128;
> ++ private static final int BLACK_PIXEL_COUNT_THRESHOLD = WIDTH * HEIGHT / 1000;
> ++
> ++ private static final String[][] testedStrings = {
> ++ {"Latin-1", "abcdefABCDEF"},
> ++ {"Latin-2", "??????????????????????????"},
> ++ {"Cyrilic", "??????????????????"},
> ++ {"Greek", "????????????????????????????????"},
> ++ {"Asia-Test1", "???????????????"},
> ++ {"Asia-Test2", "??????????????????"},
> ++ {"Asia-Test3", "???????????????"},
> ++ {"Asia-Test4", "???????????????"},
> ++ };
> ++
> ++ /**
> ++ * Creates test image a renders one big character to it.
> ++ * @param testedString
> ++ * @return
> ++ */
> ++ private BufferedImage createTestImage(String str) {
> ++ BufferedImage image = new BufferedImage(WIDTH, HEIGHT, BufferedImage.TYPE_BYTE_GRAY);
> ++ Graphics2D gc = image.createGraphics();
> ++ gc.setBackground(Color.WHITE);
> ++ gc.setRenderingHint(RenderingHints.KEY_ANTIALIASING, RenderingHints.VALUE_ANTIALIAS_OFF);
> ++ gc.setRenderingHint(RenderingHints.KEY_TEXT_ANTIALIASING, RenderingHints.VALUE_TEXT_ANTIALIAS_OFF);
> ++ gc.clearRect(0, 0, WIDTH, HEIGHT);
> ++ gc.setFont(new Font(Font.DIALOG, Font.PLAIN, FONT_SIZE));
> ++ gc.setColor(Color.BLACK);
> ++ gc.drawString(str, 0, HEIGHT - 40);
> ++ gc.dispose();
> ++ return image;
> ++ }
> ++
> ++ /**
> ++ * Creates destination image and then copies data from source image to it
> ++ * @param src
> ++ * @return
> ++ */
> ++ private BufferedImage createDestinationImage(BufferedImage src) {
> ++ BufferedImage image = new BufferedImage(WIDTH, HEIGHT, BufferedImage.TYPE_BYTE_GRAY);
> ++ src.copyData(image.getRaster());
> ++ return image;
> ++ }
> ++
> ++ /**
> ++ * Removes long horizontal lines from image
> ++ */
> ++ private void removeHorizontalLines(BufferedImage image) {
> ++ for (int y = 0; y < image.getHeight(); y++) {
> ++ int startX = -1, endX = -1;
> ++ for (int x = 0; x < image.getWidth(); x++) {
> ++ int color = image.getRaster().getSample(x, y, 0);
> ++ if (startX < 0 && color <= BLACK_WHITE_THRESHOLD) {
> ++ startX = x;
> ++ //System.out.println("> " + y + "\t" + x);
> ++ }
> ++ if (startX > 0 && endX < 0 && color > BLACK_WHITE_THRESHOLD) {
> ++ endX = x;
> ++ //System.out.println("< " + y + "\t" + x);
> ++ }
> ++ }
> ++ // remove long horizontal line, but only if this line found detected in image
> ++ if (startX > 0 && endX > 0 && (endX - startX) > MINIMUM_HORIZONTAL_LINE_LENGTH) {
> ++ for (int x = startX; x < endX; x++) {
> ++ image.getRaster().setSample(x, y, 0, 255);
> ++ }
> ++ }
> ++ }
> ++ }
> ++
> ++ /**
> ++ * Removes long vertical lines from image
> ++ */
> ++ private void removeVerticalLines(BufferedImage image) {
> ++ for (int x = 0; x < image.getWidth(); x++) {
> ++ int startY = -1, endY = -1;
> ++ for (int y = 0; y < image.getHeight(); y++) {
> ++ int color = image.getRaster().getSample(x, y, 0);
> ++ if (startY < 0 && color <= BLACK_WHITE_THRESHOLD) {
> ++ startY = y;
> ++ }
> ++ if (startY > 0 && endY < 0 && color > BLACK_WHITE_THRESHOLD) {
> ++ endY = y;
> ++ //System.out.println("< " + y + "\t" + x);
> ++ }
> ++ }
> ++ // remove long vertical line, but only if this line found detected in image
> ++ if (startY > 0 && endY > 0 && (endY - startY) > MINIMUM_VERTICAL_LINE_LENGTH) {
> ++ for (int y = startY; y < endY; y++) {
> ++ image.getRaster().setSample(x, y, 0, 255);
> ++ }
> ++ }
> ++ }
> ++ }
> ++
> ++ /**
> ++ * Test if image is almost empty (one large white area)
> ++ * @param image
> ++ * @return
> ++ */
> ++ private boolean isImageAlmostEmpty(BufferedImage image) {
> ++ int blackPixelCount = 0;
> ++ for (int y = 0; y < image.getHeight(); y++) {
> ++ for (int x = 0; x < image.getWidth(); x++) {
> ++ if (image.getRaster().getSample(x, y, 0) < BLACK_WHITE_THRESHOLD) {
> ++ blackPixelCount++;
> ++ }
> ++ }
> ++ }
> ++ return blackPixelCount < BLACK_PIXEL_COUNT_THRESHOLD;
> ++ }
> ++
> ++ public void runTest(boolean createImages) throws IOException
> ++ {
> ++ List<Integer> badCharacters = new ArrayList<Integer>();
> ++ for (String[] testedString : testedStrings) {
> ++ System.out.println("\nTesting " + testedString[0]);
> ++ for (int i = 0; i < testedString[1].length(); i++) {
> ++ String str = testedString[1].substring(i, 1+i);
> ++ int code = str.charAt(0);
> ++ System.out.print(code + "\t");
> ++ BufferedImage src = createTestImage(str);
> ++ BufferedImage dst = createDestinationImage(src);
> ++ removeHorizontalLines(dst);
> ++ removeVerticalLines(dst);
> ++
> ++ if (createImages /* || true*/) {
> ++ ImageIO.write(src, "png", new File(code + "_src.png"));
> ++ ImageIO.write(dst, "png", new File(code + "_dst.png"));
> ++ }
> ++
> ++ if (isImageAlmostEmpty(dst)) {
> ++ System.err.println("Bad rendering of character with code: " + code);
> ++ badCharacters.add(Integer.valueOf(code));
> ++ }
> ++ }
> ++ }
> ++ if (!badCharacters.isEmpty()) {
> ++ throw new RuntimeException("Error in rendering of character(s) with code(s): " + badCharacters.toString());
> ++ }
> ++ }
> ++
> ++ public static void main(String[] args) throws IOException {
> ++ new InternationalFontsRendering().runTest(Arrays.asList(args).contains("-create-images"));
> ++ }
> ++}
> ++
--
Andrew :)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the distro-pkg-dev
mailing list