Reviewer needed: patch for regression test compiler/6857159/Test6857159.java

[Dr Andrew John Hughes]

On 18:09 Thu 04 Nov     , Pavel Tisnovsky wrote:
> Hi all,
> 
> can anybody review (very simple) patch for regression test compiler/6857159/Test6857159.java please?
> 
> This test correction was already approved for OpenJDK7 and I pushed it to
> tl-gate two hours ago. But I'd like to include this correction to IcedTea6 HEAD too.
> 

Approved.

> Thank you in advance
> Pavel T.
> 
> 
> Here is diffstat for IcedTea6 HEAD:
> 
> # HG changeset patch
> # User ptisnovs
> # Date 1288886704 -3600
> # Node ID a31de5ddde0255827307549841dc51bc0268cb0c
> # Parent  a4bd79afa729b29f963bf0805c002ddaf4b6ac5b
> Correction of regression test Test6857159.
> 
> diff -r a4bd79afa729 -r a31de5ddde02 ChangeLog
> --- a/ChangeLog	Wed Nov 03 18:26:48 2010 +0000
> +++ b/ChangeLog	Thu Nov 04 17:05:04 2010 +0100
> @@ -1,3 +1,10 @@
> +2010-11-04  Pavel Tisnovsky  <ptisnovs at redhat.com>
> +
> +	* Makefile.am:
> +	* patches/openjdk/6997495-test_correction_6857159.patch:
> +	Testcase correction, now the regression test Test6857159 should not
> +	timeout on most machines.
> +
>  2010-11-03  Dan Horák <dhorak at redhat.com>
> 
>  	* patches/hotspot/hs19/params-cast-size_t.patch:
> diff -r a4bd79afa729 -r a31de5ddde02 Makefile.am
> --- a/Makefile.am	Wed Nov 03 18:26:48 2010 +0000
> +++ b/Makefile.am	Thu Nov 04 17:05:04 2010 +0100
> @@ -293,7 +293,8 @@
>  	patches/openjdk/6985992-test_6933784.patch \
>  	patches/openjdk/6853592-badwindow-warning-fix.patch \
>  	patches/6703377-freetypescaler.patch \
> -	patches/icedtea-jtreg-international-fonts.patch
> +	patches/icedtea-jtreg-international-fonts.patch \
> +	patches/openjdk/6997495-test_correction_6857159.patch
> 
>  if WITH_ALT_HSBUILD
>  ICEDTEA_PATCHES += \
> diff -r a4bd79afa729 -r a31de5ddde02 patches/openjdk/6997495-test_correction_6857159.patch
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/patches/openjdk/6997495-test_correction_6857159.patch	Thu Nov 04 17:05:04 2010 +0100
> @@ -0,0 +1,21 @@
> +# HG changeset patch
> +# User ptisnovs
> +# Date 1288875792 -3600
> +# Node ID 086898a88056cd9f7de4475b7ebf4cc6c65f2b5e
> +# Parent  68d6141ea19de3a9ba98ef753f0da41a61f736a0
> +6997495: correction of regression test compiler/6857159/Test6857159
> +Summary: Testcase correction.
> +Reviewed-by: never
> +
> +diff -r 68d6141ea19d -r 086898a88056 test/compiler/6857159/Test6857159.java
> +--- openjdk.old/hotspot/test/compiler/6857159/Test6857159.java	2010-10-08 22:29:24.000000000 +0200
> ++++ openjdk/hotspot/test/compiler/6857159/Test6857159.java	2010-11-04 15:27:47.000000000 +0100
> +@@ -54,7 +54,7 @@
> +     }
> +
> +     public static void main(String[] args) throws Exception {
> +-        for (int i = 0; i < 100000; i++) {
> ++        for (int i = 0; i < 20000; i++) {
> +             Thread t = null;
> +             switch (i % 3) {
> +               case 0: t = new ct0(); break;

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8