[icedtea-web] RFC: Patch to remove plugin re-framing

[Omair Majid]

Hi Deepak,

On 11/04/2010 04:30 PM, Deepak Bhole wrote:
> Attached patch changes the plugin so that the panel is Framed only once.
> This patch permanently resolves the frame pop-out issue.
>
> The reFrame method has been updated and renamed to framePanel.
> framePanel is called only once during initialization now, and there is
> no more frame swapping. This also resolves the issue whereby keyboard
> events were being discarded.
>
> ChangeLog:
> 2010-11-04  Deepak Bhole<dbhole at redhat.com>
>
>     * plugin/icedteanp/java/sun/applet/PluginAppletViewer.java
>     (createPanel): Call the new framePanel() method with the proper handle.
>     (framePanel): New method, renamed from reFrame. Changed to now do one-time
>     framing of panel into the plugin.
>     (handleMessage): Don't re-frame the panel. Panel is now framed only once.
>     (destroyApplet): Dispose the frame right away, and try to remove the panel
>     if possible. If not, handleMessage() will do it when the panel is
>     ready/removable.
>
> Comments?
>

The patch looks fine to me. I can confirm that it fixes the keyboard 
input problem too.

Cheers,
Omair