[icedtea-web] RFC: use an actual number as the JDK_UPDATE_VERSION for plugin

[Dr Andrew John Hughes]

On 16:18 Mon 08 Nov     , Deepak Bhole wrote:
> * Omair Majid <omajid at redhat.com> [2010-11-08 16:16]:
> > Hi,
> > 
> > The IcedTea builds used to pass in a value for JDK_UPDATE_VERSION
> > when building the plugin, which was left out when IcedTea-Web was
> > created. This patch defines this variable and sets it to an
> > arbitrary value.
> > 
> > Without this patch, about:plugins in firefox shows that the plugin
> > supports the mime type
> > "application/x-java-applet;jpi-version=1.6.0_". This seems to cause
> > issues with the deployJava.js script - the users get redirected to
> > the Java download page. Adding any value after the _ is enough to
> > make applets using deployJava.js work with the plugin.
> > 
> > The following web page can be used as a reproducer:
> > http://download.oracle.com/javase/tutorial/deployment/applet/examples/dist/applet_Draggable/AppletPage.html
> > 
> > ChangeLog:
> > 2010-11-08  Omair Majid  <omajid at redhat.com>
> > 
> >     * Makefile.am (JDKJDK_UPDATE_VERSION): Define variable.
> > 
> 
> Minor typo up there.
> 
> Looks fine otherwise. Ok for HEAD.
> 
> Deepak
> 
> > Any thoughts or comments?
> > 
> > Thanks,
> > Omair
> 
> > diff -r 8e66d9386273 Makefile.am
> > --- a/Makefile.am	Thu Nov 04 16:44:27 2010 -0700
> > +++ b/Makefile.am	Mon Nov 08 15:51:36 2010 -0500
> > @@ -17,6 +17,8 @@
> >  IT_CLASS_TARGET_VERSION=6
> >  IT_JAVACFLAGS=$(IT_JAVAC_SETTINGS) -source $(IT_LANGUAGE_SOURCE_VERSION) -target $(IT_CLASS_TARGET_VERSION)
> >  
> > +JDK_UPDATE_VERSION=50
> > +
> >  # Sources list
> >  
> >  PLUGIN_TEST_SRCS = $(abs_top_srcdir)/plugin/tests/LiveConnect/*.java
> 

Fine for me, though I wonder why you went for 50 and not just 99 :-)
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8