[icedtea-web] RFC: move a number of translatable strings into Messages.properties

[Omair Majid]

On 11/10/2010 04:14 PM, Andrew Su wrote:
>
> ----- "Omair Majid"<omajid at redhat.com>  wrote:
>
>> From: "Omair Majid"<omajid at redhat.com>
>> To: "IcedTea"<distro-pkg-dev at openjdk.java.net>
>> Sent: Wednesday, November 10, 2010 1:46:36 PM GMT -05:00 US/Canada Eastern
>> Subject: Re: [icedtea-web] RFC: move a number of translatable strings into Messages.properties
>>
>> On 11/01/2010 03:27 PM, Omair Majid wrote:
>>> Hi,
>>>
>>> The attached patch moves a number of user-visible strings to
>>> Messages.properties file. There should be no user-visible strings
>> left
>>> in any class in the package net.sourceforge.jnlp.security.*. The
>> only
>>> exception is AppletWarningPane which I have not modified as it is
>>> currently unused.
>>>
>>
>> Updated patch attached. This works with the updated certificate
>> viewer.
>>
>> 2010-11-09  Omair Majid<omajid at redhat.com>
>>
>>        * netx/net/sourceforge/jnlp/resources/Messages.properties: Add
>>        ButAllow, ButClose, ButCopy, ButMoreInformation, ButProceed,
>>        ButRun, AlwaysAllowAction, Continue, Field, From, Name,
>> Publisher,
>>        Value, Version, SNoAssociatedCertificate,
>> SAlwaysTrustPublisher,
>>        SHttpsUnverified, SNotAllSignedSummary, SNotAllSignedDetail,
>>        SNotAllSignedQuestion, SCertificateDetails, SIssuer, SSerial,
>>        SMD5Fingerprint, SSHA1Fingerprint, SSignature,
>> SSignatureAlgorithm,
>>        SSubject, SValidity, CVCertificateViewer, CVDetails,
>> CVIssuedTo,
>>        CVExport, CVImport, CVIssuedBy, IssuedTo, CVRemove,
>>        CVRemoveConfirmMessage,CVRemoveConfirmTitle, CVUser, CVSystem,
>>        KS, KSCerts, KSJsseCerts, KSCaCerts, KSJsseCaCerts, and
>>        KSClientCerts.
>>        * netx/net/sourceforge/jnlp/security/AccessWarningPane.java
>>        (addComponents): Use localized strings.
>>        * netx/net/sourceforge/jnlp/security/CertWarningPane.java
>>        (addComponents): Likewise.
>>        * netx/net/sourceforge/jnlp/security/CertsInfoPane.java
>>        (parseCert): Likewise.
>>        (addComponents): Likewise.
>>        * netx/net/sourceforge/jnlp/security/MoreInfoPane.java
>>        (addComponents): Likewise.
>>        *
>> netx/net/sourceforge/jnlp/security/NotAllSignedWarningPane.java
>>        (addComponents): Likewise.
>>        *
>> netx/net/sourceforge/jnlp/security/viewer/CertificatePane.java:
>>        Likewise.
>>        (addComponents): Likewise.
>>        (CertificateType.toString): Likewise.
>>        (RemoveButtonListener.actionPerformed): Likewise.
>>
>>
>> Any comments?
>
> Hello,
>
> These changes look good to me, ok to commit.
>

Thanks for the review Andrew! I have pushed the changes. I suppose the 
next logical thing to do would be to announce that we are looking for 
translations.

Cheers,
Omair