Reviewer needed - really simple correction of regression test hotspot/test/gc/6581734/Test6581734

[Dr Andrew John Hughes]

On 16:39 Thu 11 Nov     , Pavel Tisnovsky wrote:
> Hi,
> 
> can anyone please review patch containing really simple correction of
> regression test
> hotspot/test/gc/6581734/Test6581734?
> 
> (as you can see, only right bracket is added to the proper place - one
> extra character generated by patch of size 828 bytes ;-)
> 
> diffstat produced against IcedTea6 HEAD is stored in attachment
> 
> 
> Thank you in advance
> Pavel T.

Approved. Please commit.

It's probably worth asking for the backport to go into OpenJDK6 too.

> # HG changeset patch
> # User ptisnovs
> # Date 1289489057 -3600
> # Node ID 92aee772112bffe05772845b59cc9ebdf184f983
> # Parent  3b0958812397b60d1c172a6cfe44d7b4e072cf1c
> Testcase correction - added missing right bracket.
> 
> diff -r 3b0958812397 -r 92aee772112b ChangeLog
> --- a/ChangeLog	Wed Nov 10 16:07:00 2010 +0000
> +++ b/ChangeLog	Thu Nov 11 16:24:17 2010 +0100
> @@ -1,3 +1,9 @@
> +2010-11-11  Pavel Tisnovsky  <ptisnovs at redhat.co>
> +
> +	* Makefile.am: Add new patch.
> +	* patches/openjdk/6980392-fix_test6581734.patch:
> +	Testcase correction - added missing right bracket.
> +
>  2010-11-10  Andrew John Hughes  <ahughes at redhat.com>
>  
>  	RH647737
> diff -r 3b0958812397 -r 92aee772112b Makefile.am
> --- a/Makefile.am	Wed Nov 10 16:07:00 2010 +0000
> +++ b/Makefile.am	Thu Nov 11 16:24:17 2010 +0100
> @@ -306,7 +306,8 @@
>  if WITH_ALT_HSBUILD
>  ICEDTEA_PATCHES += \
>  	patches/openjdk/6994130-ppc_fix.patch \
> -	patches/disable-default-compoops.patch
> +	patches/disable-default-compoops.patch \
> +	patches/openjdk/6980392-fix_test6581734.patch
>  else
>  ICEDTEA_PATCHES += \
>  	patches/shark_do_nothing_on_stub_frame.patch \
> diff -r 3b0958812397 -r 92aee772112b patches/openjdk/6980392-fix_test6581734.patch
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/patches/openjdk/6980392-fix_test6581734.patch	Thu Nov 11 16:24:17 2010 +0100
> @@ -0,0 +1,21 @@
> +# HG changeset patch
> +# User kevinw
> +# Date 1282924624 -3600
> +# Node ID 21c29458b334f7b1f05a185442ab37ab8de1ea7b
> +# Parent  8e5955ddf8e491a54b7e9446424fdee02e6950c8
> +6980392: TEST_BUG: gc/6581734/Test6581734.java has typo
> +Summary: simple correction in testcase
> +Reviewed-by: mchung
> +
> +diff -r 8e5955ddf8e4 -r 21c29458b334 test/gc/6581734/Test6581734.java
> +--- openjdk.old/hotspot/test/gc/6581734/Test6581734.java	2010-10-08 22:29:24.000000000 +0200
> ++++ openjdk/hotspot/test/gc/6581734/Test6581734.java	2010-11-11 15:47:15.000000000 +0100
> +@@ -121,7 +121,7 @@
> +         }
> + 
> +         if (collectorsWithTime<collectorsFound) {
> +-            throw new RuntimeException("collectors found with zero time";
> ++            throw new RuntimeException("collectors found with zero time");
> +         }
> +         System.out.println("Test passed.");
> +     }


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8