Reviewer needed - two corrections in JTreg test harness

[Dr Andrew John Hughes]

On 15:26 Mon 22 Nov     , Pavel Tisnovsky wrote:
> Hi Mark,
> 
> Mark Wielaard wrote:
> > Hi pavel,
> > 
> > On Mon, 2010-11-22 at 14:53 +0100, Pavel Tisnovsky wrote:
> >> can anybody please review two corrections I made in JTreg test harness tool?
> > 
> > Are the changes from the newer jtreg? The version included in icedtea
> > (see tests/jtreg/README) are based on jtreg-4_0-src-b02-15_oct_2008. The
> > latest version on java.net is jtreg-4.1-src-b02_21_may_2010
> > http://download.java.net/openjdk/jtreg/ 
> 
> Yes I know about this and initially I also tried to backport 4.1 version
> to IcedTea6, but it's quite hard as Andrew said ;-) And I don't want to
> broke the tool which work quite good for as for more than two years.
> 
> The changes are actually based on 4.1 version but I tried to change as
> little thinks as possible (it's not an 1:1 copy from 4.1 sources).
> 

Ok so that answers the first question I had (where did these changes come from?).

If we're going to update jtreg, I'd prefer we update to a known version, not
cherry-pick individual changes.  So the in-tree version should be updated to 4.1.

As this is a big change, I'd prefer we delay it until after 1.10 branches.

> > 
> > Since the changes seem to come from the newer jtreg I think you should
> > feel free to add them. But please do make a note about which version you
> > took the changes from in the tests/jtreg/README.
> 
> Will do...
> 
> > 
> > Thanks,
> > 
> > Mark
> > 
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8