Reviewer needed - two corrections in JTreg test harness

[Pavel Tisnovsky]

Dr Andrew John Hughes wrote:
> On 16:08 Mon 22 Nov     , Pavel Tisnovsky wrote:
>> Dr Andrew John Hughes wrote:
>>> On 15:26 Mon 22 Nov     , Pavel Tisnovsky wrote:
>>>> Hi Mark,
>>>>
>>>> Mark Wielaard wrote:
>>>>> Hi pavel,
>>>>>
>>>>> On Mon, 2010-11-22 at 14:53 +0100, Pavel Tisnovsky wrote:
>>>>>> can anybody please review two corrections I made in JTreg test harness tool?
>>>>> Are the changes from the newer jtreg? The version included in icedtea
>>>>> (see tests/jtreg/README) are based on jtreg-4_0-src-b02-15_oct_2008. The
>>>>> latest version on java.net is jtreg-4.1-src-b02_21_may_2010
>>>>> http://download.java.net/openjdk/jtreg/ 
>>>> Yes I know about this and initially I also tried to backport 4.1 version
>>>> to IcedTea6, but it's quite hard as Andrew said ;-) And I don't want to
>>>> broke the tool which work quite good for as for more than two years.
>>>>
>>>> The changes are actually based on 4.1 version but I tried to change as
>>>> little thinks as possible (it's not an 1:1 copy from 4.1 sources).
>>>>
>>> Ok so that answers the first question I had (where did these changes come from?).
>>>
>>> If we're going to update jtreg, I'd prefer we update to a known version, not
>>> cherry-pick individual changes.  So the in-tree version should be updated to 4.1.
>> I'd like to update JTreg to 4.1 but it takes some time. In the meantime
>> I thought it would be good to have JTreg not-yet-updated but at least
>> corrected.
>>
>>> As this is a big change, I'd prefer we delay it until after 1.10 branches.
>>>
>>>>> Since the changes seem to come from the newer jtreg I think you should
>>>>> feel free to add them. But please do make a note about which version you
>>>>> took the changes from in the tests/jtreg/README.
>>>> Will do...
>>>>
>>>>> Thanks,
>>>>>
>>>>> Mark
>>>>>
> 
> Ok please post a new version of the patch with appropriate README updates to describe
> the changes and we'll consider that for 1.10.  Once 1.10 branches, I'd like to see
> a full update to 4.1 go in.

Andrew and Mark,

thanks for your reviews!

Updated version of the JTreg fix is stored in an attachment.

Pavel

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: hg_export
Url: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20101122/81d51dde/hg_export.ksh