[Bug 599] New: plugin: mutex and memory leak

[bugzilla-daemon at icedtea.classpath.org]

http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=599

           Summary: plugin: mutex and memory leak
           Product: IcedTea
           Version: unspecified
          Platform: all
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: IcedTea6
        AssignedTo: unassigned at icedtea.classpath.org
        ReportedBy: pcpa at mandriva.com.br


I made the attached patch for mandriva java-1.6.0-openjdk package
when updating to use icedtea6-1.8.2 and posted about it on mailing
lists, but unfortunately I did not open a bug report neither extend
the patch, but the problems are still present in icedtea6-1.8.3.

  Problems:
1. start_jvm_if_needed() allocates memory for a mutex in a local
   variable, initializes it, and locks it; this will not prevent
   concurrent access because the mutex is in stack storage, but it
   also returns, with the mutex locked,  f the jvm was already started
2. the memory leak is when there are no consumers in MessageBus::post
   as it expects the first consumer to release the memory
3. also in MessageBus::Post the debug says:
        PLUGIN_DEBUG("Trying to lock %p...\n", &msg_queue_mutex);
   but the next line is:
        pthread_mutex_lock(&subscriber_mutex);
   so the patch also actually locks the mutex being advertised as being
   locked. In this case I am not 100% sure if order of lock/unlock is
   correct.

  I did this patch, and it corrected most issues where I use/test
openjdk, that is in my mandriva package of sagemath, that can open
several jmol plugins. But it does not correct all, and frequently
it will dead lock, and need to kill the jvm, so, there should be
still other issues that may lead to deadlocks with multiple plugins
running concurrently.


-- 
Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.