[icedtea-web] fails to build with an older netx.jar on the path

[Dr Andrew John Hughes]

On 16:04 Wed 24 Nov     , Omair Majid wrote:
> On 11/24/2010 03:59 PM, Dr Andrew John Hughes wrote:
> > On 12:25 Wed 24 Nov     , Omair Majid wrote:
> >> On 11/24/2010 08:16 AM, Matthias Klose wrote:
> >>> I had an older ./usr/lib/jvm/java-6-openjdk/jre/lib/netx.jar
> >>> installed on the system, then the build fails with:
> >>>
> >>> /scratch/packages/openjdk/web/icedtea-web-1.0~20101124/build/../plugin/icedteanp/java/sun/applet/PluginMain.java:126:
> >>> cannot find symbol
> >>> symbol : method setRedirectStreams(boolean)
> >>> location: class net.sourceforge.jnlp.runtime.JNLPRuntime
> >>> JNLPRuntime.setRedirectStreams(redirectStreams);
> >>> ^
> >>> /scratch/packages/openjdk/web/icedtea-web-1.0~20101124/build/../plugin/icedteanp/java/sun/applet/PluginMain.java:203:
> >>> cannot find symbol
> >>> symbol : method getConfiguration()
> >>> location: class net.sourceforge.jnlp.runtime.JNLPRuntime
> >>> boolean installAuthenticator =
> >>> Boolean.valueOf(JNLPRuntime.getConfiguration()
> >>> ^
> >>>
> >>> looks like the -bootclasspath needs to be set to find the current netx.
> >>>
> >>
> >> The netx build sets the bootclasspath correctly, the attached patch does
> >> it for the plugin. Does this fix the issue?
> >>
> >> Thanks,
> >> Omair
> >
> >> diff -r 476a91d02140 Makefile.am
> >> --- a/Makefile.am	Wed Nov 24 10:55:50 2010 -0500
> >> +++ b/Makefile.am	Wed Nov 24 12:20:07 2010 -0500
> >> @@ -186,6 +186,7 @@
> >>   	  $(BOOT_DIR)/bin/javac $(IT_JAVACFLAGS) \
> >>   	      -d $(abs_top_builddir)/liveconnect \
> >>   	      -classpath $(NETX_DIR):$(RUNTIME) \
> >> +	      -bootclasspath $(RUNTIME) \
> >>   	      -sourcepath $(LIVECONNECT_SRCS) \
> >>   	      @liveconnect-source-files.txt ; \
> >>   	fi
> >
> > I guess it will, but I'm not sure how far we can support such scenarios.  There's
> > obviously no way around the fact that NetX and the plugin are in rt.jar for 1.7&  1.8.
> >
> > The recommended solution is to rebuild with the old plugin and webstart disabled.
> 
> I agree, but the original email is about an older netx.jar. If 
> icedtea-web has been installed into a JDK, that JDK is used to build the 
> plugin and the version of plugin being built expects a slightly 
> different netx api, then it will fail with these exceptions. I have seen 
> them a number of times myself while working on netx code.
> 
> Cheers,
> Omair

BTW, you should take $(RUNTIME) off the classpath if you're going to do this.
Also, have you tested this? IIRC, we needed tools.jar at one point.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8