Reviewer needed - fix for regression test java/awt/Insets/WindowWithWarningTest/WindowWithWarning

[Pavel Tisnovsky]

Dr Andrew John Hughes wrote:
> On 19:41 Fri 26 Nov     , Pavel Tisnovsky wrote:
>> Hi all,
>>
>> can anyone please review fix for regression test
>> java/awt/Insets/WindowWithWarningTest/WindowWithWarning? Mercurial
>> export for IcedTea6 HEAD (1.10pre) is included in this mail as attachment.
>>
>> Description of the fix:
>>
>> This test must be run in an environment similar to sandbox used for
>> running regular applets, which among other things means that each window
>> created by the test itself has to be labelled by warning message "Java
>> Applet Window".
>>
>> But for the test to (probably successfuly) proceed it is also required
>> that AWT Robot is enabled (and it is disabled by default for applets,
>> which reasonable, of course).
>>
>> To guarantee both conditions to run this test I copied system security
>> policy file, added new line to enable AWT robot and then configured the
>> test itself to use this policy file, because JTreg harness usually
>> starts such tests (applets) without security manager installed.
>>
>> PS: I've made this fix with great help of Andrew, Deepak and Omair -
>> thank you very much colleagues!
>>
>> Cheers
>> Pavel
> 
> This looks pretty standard, compared with other JDK tests.
> 
> Could we not just allow the needed robot permission?  Are all the ones
> for the policy file really needed?

Hi Andrew,

you are right, I've tried to run this test with simplified policy file.
Second version of test fix is included in attachment - can you please
review it?

Btw, is it possible to use webrev instead of hg export to send changes
for review? It might be easier to read (but I'm not sure if it's
possible to use webrev tool from Sun/Oracle to another project than
OpenJDK).

Pavel
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: hg_export
Url: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20101129/2fd0a00a/hg_export.ksh