[RFC][icedtea-web]: Adding control panel to icedtea-web

[Omair Majid]

On 11/29/2010 04:14 PM, Andrew Su wrote:
> Hello,
>
> Here is the updated patch for adding the control panel. If I missed
> something let me know.
>
> Right now I've left netx/net/sourceforge/jnlp/security/viewer/* and not
> deleted them.
> It is currently copied into org/classpath/icedtea/controlpanel/ but I
> was looking at javaws, which uses the viewer.
> Our options are to either remove, the parameter "-viewer" for javaws
> (for now) then later re-place it back in...
> or to leave netx/net/sourceforge/jnlp/security/viewer/* as it is.
>

I dont see why netx should have a copy of certificate viewer. In my 
opinion, certificate viewer (CertficateViewer and CertificatePane) 
should be removed from netx. The "-viewer" option should be kept and it 
should invoke control panel if possible.

FWIW, even removing the "-viewer" option might be acceptable. It is 
named exactly the same as the option in the proprietary javaws, but it 
does something quite different. IMO, we should try to avoid such surprises.

>
> * Makefile.am:
> (CONTROLPANEL_DIR): Build directory for control panel.
> (CONTROLPANEL_SRCDIR): Source directory for control panel.
> (CONTROLPANEL_LAUNCHER_OBJECTS): Objects used to compile binary
> control panel.
> (all-local): Add stamps/controlpanel-dist.stamp
> stamps/controlpanel.stamp $(CONTROLPANEL_DIR)/launcher/controlpanel.
> (clean-local): Add clean-controlpanel.
> (install-exec-local): Install the control panel jar file and control
> panel binary.
> (uninstall-local): Delete controlpanel.jar and controlpanel binary
> from installed location.
> (controlpanel-source-files.txt): Get the list of source files for
> control panel.
> (stamps/controlpanel.stamp): Compile the java files for control panel.
> (stamps/controlpanel-dist.stamp): Depend on stamps/controlpanel.stamp.
> Create the jar file for control panel.
> ($(CONTROLPANEL_DIR)/launcher/%.o): Create the launcher objects.
> ($(CONTROLPANEL_DIR)/launcher/controlpanel): Link the objects to make
> the launcher.
> (clean-controlpanel): Remove the compiled control panel.
> (controlpanel): Calls stamps/controlpanel.stamp.
> (controlpanel-dist): Calls stamps/controlpanel-dist.stamp.
> (stamps/docs.stamp): Calls stamps/controlpanel-docs.stamp.
> (clean-docs): Calls clean-controlpanel-docs.
> (stamps/controlpanel-docs.stamp): Create the documentation for
> controlpanel.
> (clean-controlpanel-docs): Remove the documentation
> * controlpanel/org/classpath/icedtea/controlpanel/AboutPanel.java,
> * controlpanel/org/classpath/icedtea/controlpanel/ComboItem.java,
> * controlpanel/org/classpath/icedtea/controlpanel/ControlPanel.java,
> * controlpanel/org/classpath/icedtea/controlpanel/DebuggingPanel.java,
> *
> controlpanel/org/classpath/icedtea/controlpanel/DesktopShortcutPanel.java,
> * controlpanel/org/classpath/icedtea/controlpanel/JREPanel.java,
> * controlpanel/org/classpath/icedtea/controlpanel/NamedBorderPanel.java,
> *
> controlpanel/org/classpath/icedtea/controlpanel/SecuritySettingsPanel.java,
> *
> controlpanel/org/classpath/icedtea/controlpanel/TemporaryInternetFilesPanel.java,
>
> *
> controlpanel/org/classpath/icedtea/controlpanel/network/AdvancedProxySettingsDialog.java,
>
> *
> controlpanel/org/classpath/icedtea/controlpanel/network/AdvancedProxySettingsPane.java,
>
> *
> controlpanel/org/classpath/icedtea/controlpanel/network/NetworkSettingsPanel.java,
>
> *
> controlpanel/org/classpath/icedtea/controlpanel/security/viewer/CertificatePane.java,
>
> *
> controlpanel/org/classpath/icedtea/controlpanel/security/viewer/CertificateViewer.java:
>
> New classes. All methods are new as well.
> *
> controlpanel/org/classpath/icedtea/controlpanel/translator/Translator.java:
> Copied over from netx/net/sourceforge/jnlp/runtime/Translator.java and
> changed package.

Is there a reason for the tiny security.viewer and translator 
subackpages? Are there any problems with just adding CertificatePane and 
Translator to org.classpath.icedtea.controlpanel? CertificateViewer 
should be completely removed - are you even using it?

Omair

> * netx/net/sourceforge/jnlp/resources/Messages.properties: Added
> messages for control panel.
>
>