[RFC][icedtea-web]: Adding control panel to icedtea-web

[Andrew Su]

Hello,

The attached patch is to move the control panel into netx instead of having its own package.

ChangeLog:
        * Makefile.am:
        (CONTROLPANEL_LAUNCHER_OBJECTS): Objects used to compile binary
        control panel.
        (all-local): Add $(NETX_DIR)/launcher/controlpanel/controlpanel.
        (install-exec-local): Install the control panel binary.
        (uninstall-local): Removes the compiled control panel binary.
        ($(NETX_DIR)/launcher/controlpanel/%.o): Create the launcher objects.
        ($(NETX_DIR)/launcher/controlpanel/controlpanel): Link the objects to 
        make the launcher.
        * netx/net/sourceforge/jnlp/controlpanel/AboutPanel.java,
        * netx/net/sourceforge/jnlp/controlpanel/ComboItem.java,
        * netx/net/sourceforge/jnlp/controlpanel/ControlPanel.java,
        * netx/net/sourceforge/jnlp/controlpanel/DebuggingPanel.java,
        * netx/net/sourceforge/jnlp/controlpanel/DesktopShortcutPanel.java,
        * netx/net/sourceforge/jnlp/controlpanel/JREPanel.java,
        * netx/net/sourceforge/jnlp/controlpanel/NamedBorderPanel.java,
        * netx/net/sourceforge/jnlp/controlpanel/SecuritySettingsPanel.java,
        * netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java,
        * netx/net/sourceforge/jnlp/controlpanel/network/AdvancedProxySettingsDialog.java,
        * netx/net/sourceforge/jnlp/controlpanel/network/AdvancedProxySettingsPane.java,
        * netx/net/sourceforge/jnlp/controlpanel/network/NetworkSettingsPanel.java,:
        New classes. All methods are new as well.
        * netx/net/sourceforge/jnlp/resources/Messages.properties: Added
        messages used by control panel. 
        * netx/net/sourceforge/jnlp/security/viewer/CertificatePane.java: 
        Changed to not display a close button if null parent frame.

Questions? Comments? Concerns?

--Andrew



----- "Andrew Su" <asu at redhat.com> wrote:

> From: "Andrew Su" <asu at redhat.com>
> To: distro-pkg-dev at openjdk.java.net
> Sent: Monday, November 29, 2010 4:14:26 PM GMT -05:00 US/Canada Eastern
> Subject: Re: [RFC][icedtea-web]: Adding control panel to icedtea-web
>
> Hello,
> 
> Here is the updated patch for adding the control panel. If I missed 
> something let me know.
> 
> Right now I've left netx/net/sourceforge/jnlp/security/viewer/* and
> not 
> deleted them.
> It is currently copied into org/classpath/icedtea/controlpanel/ but I
> 
> was looking at javaws, which uses the viewer.
> Our options are to either  remove, the parameter "-viewer" for javaws
> 
> (for now) then later re-place it back in...
> or to leave netx/net/sourceforge/jnlp/security/viewer/* as it is.
> 
> Opinions?
> 
>          * Makefile.am:
>          (CONTROLPANEL_DIR): Build directory for control panel.
>          (CONTROLPANEL_SRCDIR): Source directory for control panel.
>          (CONTROLPANEL_LAUNCHER_OBJECTS): Objects used to compile
> binary
>          control panel.
>          (all-local): Add stamps/controlpanel-dist.stamp
>          stamps/controlpanel.stamp 
> $(CONTROLPANEL_DIR)/launcher/controlpanel.
>          (clean-local): Add clean-controlpanel.
>          (install-exec-local): Install the control panel jar file and
> 
> control
>          panel binary.
>          (uninstall-local): Delete controlpanel.jar and controlpanel
> binary
>          from installed location.
>          (controlpanel-source-files.txt): Get the list of source files
> for
>          control panel.
>          (stamps/controlpanel.stamp): Compile the java files for
> control 
> panel.
>          (stamps/controlpanel-dist.stamp): Depend on 
> stamps/controlpanel.stamp.
>          Create the jar file for control panel.
>          ($(CONTROLPANEL_DIR)/launcher/%.o): Create the launcher
> objects.
>          ($(CONTROLPANEL_DIR)/launcher/controlpanel): Link the objects
> 
> to make
>          the launcher.
>          (clean-controlpanel): Remove the compiled control panel.
>          (controlpanel): Calls stamps/controlpanel.stamp.
>          (controlpanel-dist): Calls stamps/controlpanel-dist.stamp.
>          (stamps/docs.stamp): Calls stamps/controlpanel-docs.stamp.
>          (clean-docs): Calls clean-controlpanel-docs.
>          (stamps/controlpanel-docs.stamp): Create the documentation
> for 
> controlpanel.
>          (clean-controlpanel-docs): Remove the documentation
>          *
> controlpanel/org/classpath/icedtea/controlpanel/AboutPanel.java,
>          *
> controlpanel/org/classpath/icedtea/controlpanel/ComboItem.java,
>          * 
> controlpanel/org/classpath/icedtea/controlpanel/ControlPanel.java,
>          * 
> controlpanel/org/classpath/icedtea/controlpanel/DebuggingPanel.java,
>          * 
> controlpanel/org/classpath/icedtea/controlpanel/DesktopShortcutPanel.java,
>          *
> controlpanel/org/classpath/icedtea/controlpanel/JREPanel.java,
>          * 
> controlpanel/org/classpath/icedtea/controlpanel/NamedBorderPanel.java,
>          * 
> controlpanel/org/classpath/icedtea/controlpanel/SecuritySettingsPanel.java,
>          * 
> controlpanel/org/classpath/icedtea/controlpanel/TemporaryInternetFilesPanel.java,
>          * 
> controlpanel/org/classpath/icedtea/controlpanel/network/AdvancedProxySettingsDialog.java,
>          * 
> controlpanel/org/classpath/icedtea/controlpanel/network/AdvancedProxySettingsPane.java,
>          * 
> controlpanel/org/classpath/icedtea/controlpanel/network/NetworkSettingsPanel.java,
>          * 
> controlpanel/org/classpath/icedtea/controlpanel/security/viewer/CertificatePane.java,
>          * 
> controlpanel/org/classpath/icedtea/controlpanel/security/viewer/CertificateViewer.java:
>          New classes. All methods are new as well.
>          * 
> controlpanel/org/classpath/icedtea/controlpanel/translator/Translator.java:
>          Copied over from 
> netx/net/sourceforge/jnlp/runtime/Translator.java and changed
> package.
>          * netx/net/sourceforge/jnlp/resources/Messages.properties:
> Added
>          messages for control panel.
> 
> 
-- Snip --
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20101130_controlpanel.patch
Type: text/x-patch
Size: 88709 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20101130/a8bb8246/20101130_controlpanel.patch