[RFC][icedtea-web]: Adding control panel to icedtea-web

[Andrew Su]

On 11/30/2010 11:59 AM, Dr Andrew John Hughes wrote:
> On 11:00 Tue 30 Nov     , Andrew Su wrote:
>> Hello,
>>
>> The attached patch is to move the control panel into netx instead of having its own package.
>>
>> ChangeLog:
>>          * Makefile.am:
>>          (CONTROLPANEL_LAUNCHER_OBJECTS): Objects used to compile binary
>>          control panel.
>>          (all-local): Add $(NETX_DIR)/launcher/controlpanel/controlpanel.
>>          (install-exec-local): Install the control panel binary.
>>          (uninstall-local): Removes the compiled control panel binary.
>>          ($(NETX_DIR)/launcher/controlpanel/%.o): Create the launcher objects.
>>          ($(NETX_DIR)/launcher/controlpanel/controlpanel): Link the objects to
>>          make the launcher.
>>          * netx/net/sourceforge/jnlp/controlpanel/AboutPanel.java,
>>          * netx/net/sourceforge/jnlp/controlpanel/ComboItem.java,
>>          * netx/net/sourceforge/jnlp/controlpanel/ControlPanel.java,
>>          * netx/net/sourceforge/jnlp/controlpanel/DebuggingPanel.java,
>>          * netx/net/sourceforge/jnlp/controlpanel/DesktopShortcutPanel.java,
>>          * netx/net/sourceforge/jnlp/controlpanel/JREPanel.java,
>>          * netx/net/sourceforge/jnlp/controlpanel/NamedBorderPanel.java,
>>          * netx/net/sourceforge/jnlp/controlpanel/SecuritySettingsPanel.java,
>>          * netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java,
>>          * netx/net/sourceforge/jnlp/controlpanel/network/AdvancedProxySettingsDialog.java,
>>          * netx/net/sourceforge/jnlp/controlpanel/network/AdvancedProxySettingsPane.java,
>>          * netx/net/sourceforge/jnlp/controlpanel/network/NetworkSettingsPanel.java,:
>>          New classes. All methods are new as well.
>>          * netx/net/sourceforge/jnlp/resources/Messages.properties: Added
>>          messages used by control panel.
>>          * netx/net/sourceforge/jnlp/security/viewer/CertificatePane.java:
>>          Changed to not display a close button if null parent frame.
>>
>> Questions? Comments? Concerns?
>>
> I haven't looked at the code but good to see it back in a sensible place.
> I presume it compiles?
Yes it compiles, installs, and executes.
> As to the Makefile changes, you need to resync against current HEAD. The following
> updates are needed:
>
> * $(NETX_DIR)/launcher/controlpanel/controlpanel creates a useless launcher directory
> * The installation now uses $(INSTALL)
Removed the mkdir -p launcher.
Changed to use $(INSTALL).
> Or in other words, make sure that make distcheck still works and you haven't just broken it.
make distcheck fails to pass on head without my patch...
> I don't think controlpanel is a very clear name for the binary.  itweb-settings?  Something
> that makes it clear what it controls.  It's going to be quite confusing if this ends up on
> the main path as 'controlpanel'.
name changed to itweb-settings as suggested.
> Also in your Javadoc comments, use '(' and ')' for e-mail addresses as '<' and'>' are used
> for HTML tags.
Changed to '(' and ')'.

Thanks for looking it over.

Cheers,
   Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20101130_controlpanel_v2.patch
Type: text/x-patch
Size: 88815 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20101130/60f57f4f/20101130_controlpanel_v2.patch