[RFC] [Plugin] Removing redundant call to reframe.

[Andrew Su]

----- "Deepak Bhole" <dbhole at redhat.com> wrote:

> From: "Deepak Bhole" <dbhole at redhat.com>
> To: "Andrew Su" <asu at redhat.com>
> Cc: distro-pkg-dev at openjdk.java.net
> Sent: Friday, October 1, 2010 11:14:28 AM GMT -05:00 US/Canada Eastern
> Subject: Re: [RFC] [Plugin] Removing redundant call to reframe.
>
> * Andrew Su <asu at redhat.com> [2010-10-01 11:00]:
> > Hello,
> > 
> > This attached patch is to remove the redundant call to reframe,
> since we already have the handle in our message we simply set it
> instead of assigning it to 0.
> > 
> > Cheers,
> >   Andrew
> 
> > diff -r 14ed93e7ecc5
> plugin/icedteanp/java/sun/applet/PluginAppletViewer.java
> > --- a/plugin/icedteanp/java/sun/applet/PluginAppletViewer.java	Thu
> Sep 30 11:10:01 2010 +0100
> > +++ b/plugin/icedteanp/java/sun/applet/PluginAppletViewer.java	Fri
> Oct 01 10:52:32 2010 -0400
> > @@ -140,7 +140,7 @@
> >           
> >  
> >           // put inside initial 0 handle frame
> > -         PluginAppletViewer.reFrame(null, identifier, System.out,
> 0, panel);
> > +         PluginAppletViewer.reFrame(null, identifier, System.out,
> handle, panel);
> >           
> >           panel.init();
> >  
> > @@ -557,10 +557,6 @@
> >  
> >                   if
> (!status.get(identifier).equals(PAV_INIT_STATUS.INIT_COMPLETE))
> >                       throw new Exception("Applet initialization
> timeout");
> > -
> > -                 PluginAppletViewer oldFrame =
> applets.get(identifier);
> > -                 reFrame(oldFrame, oldFrame.identifier,
> oldFrame.statusMsgStream, 
> > -                         handle, oldFrame.panel);
> >                   
> >               } else {
> >                   PluginDebug.debug ("Handling message: " + message
> + " instance " + identifier + " " + Thread.currentThread());
> 
> Looks good. This change should have gone in with the previous
> serialization commit but was missed.
> 
> Is any other part of the code other than above calling reFrame()? If
> not, that method should be removed altogether as well.
Only createPanel calls reframe now.

> 
> Cheers,
> Deepak

--Andrew