/hg/icedtea6: Makefile.am (stamps/add-netx.stamp): Create target...

[Dr Andrew John Hughes]

On 14:28 Tue 12 Oct     , Matthias Klose wrote:
> On 12.10.2010 14:20, Dr Andrew John Hughes wrote:
> > We already discussed this previously; if these directories are not
> > present, it indicates that the JDK has not been built.
> 
> yes, that's expected and explicitly configured for --with-additional-vms=zero
> 
> > I think a better solution would be to test if the directory exists,
> > rather than just creating it, so we don't end up with one man page
> > being installed on its own.  We also need to cover the add-netx-debug
> > case.
> 
> I don't see why checking for the existence of the directory is better. the jar 
> files are installed anyway, just because the lib dir happens to exist? To be 
> consistent you should disable these installations too.
> 

I'm not saying it's ideal, but I think it's better than having an incomplete man
directory.

I'm not sure how to handle the lib directory issue.  Is there a way of determining
whether one of these incomplete builds has been done?  And how is that different
from a screwed up build?

My worry with working around the valid-but-incomplete HotSpot build case is we allow
through completely broken builds.

> the build in zerovm *is* an incomplete build, which is moved into the primary build.

Yeah, I didn't realise this.

> 
>    Matthias

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8