Patch which fixes bug #6853592

Omair Majid omajid at redhat.com
Fri Oct 15 07:01:31 PDT 2010


Hi Pavel,

On 10/15/2010 08:33 AM, Pavel Tisnovsky wrote:
> Hi all,
>
> I'd like to add new patch to IcedTea6 HEAD and then backport it to
> previous IcedTea versions (beginning IcedTea6-1.6). This patch fixes bug
> #6853592 mentioned here:
> http://bugs.sun.com/view_bug.do?bug_id=6853592
> which was introduced to IcedTea6 by another patch
> 6678385-window_movement_crasher.patch
>

Ah, nice catch! I had seen the error myself a few times, but could never 
find out what was causing it. Could you please backport it to openjdk6 too?

>
> Reproducer(s):
> - it's possible to reproduce this bug by repeatedly starting&  closing
> test harness GUI (test harness is bundled with IcedTea itself):
>
> cd path_to_icedtea6/test/jtreg
> path_to_tested_jdk/bin/java -jar jtreg.jar -gui
> path_to_icedtea6/openjdk/hotspot/test
>
>
>
> Attachments in this mail:
>
> hg_export_openjdk7.diff - original export from OpenJDK7, the patch is
> based on this export
>
> 6853592-BadWindow-warning-fix.patch - the patch itself
>

This may be me being a little pedantic, but all other patches have file 
names in all lower case. Could you please rename the patch to something 
like 6853592-badwindow-warning-fix.patch when you add it to IcedTea6?

> hg_export_icedtea6.diff - changes I would like to do in IcedTea
>

Can you please ensure that the additions to ChangeLog are based on a 
line width of 80 chars?

Everything else looks good to me.

Cheers,
Omair



More information about the distro-pkg-dev mailing list