Patch which fixes bug #6853592

[Dr Andrew John Hughes]

On 16:14 Fri 15 Oct     , Pavel Tisnovsky wrote:
> Hi Omair,
> 
> thank you for your comments!
> 
> Omair Majid wrote:
> > Hi Pavel,
> > 
> > On 10/15/2010 08:33 AM, Pavel Tisnovsky wrote:
> >> Hi all,
> >>
> >> I'd like to add new patch to IcedTea6 HEAD and then backport it to
> >> previous IcedTea versions (beginning IcedTea6-1.6). This patch fixes bug
> >> #6853592 mentioned here:
> >> http://bugs.sun.com/view_bug.do?bug_id=6853592
> >> which was introduced to IcedTea6 by another patch
> >> 6678385-window_movement_crasher.patch
> >>
> > 
> > Ah, nice catch! I had seen the error myself a few times, but could never
> > find out what was causing it.
> 
> yeah it tooks me some time figure out what causes this error ;-)
> 
> >Could you please backport it to openjdk6 too?
> 
> Yes, I'm going to do it.
> 
> > 
> >>
> >> Reproducer(s):
> >> - it's possible to reproduce this bug by repeatedly starting&  closing
> >> test harness GUI (test harness is bundled with IcedTea itself):
> >>
> >> cd path_to_icedtea6/test/jtreg
> >> path_to_tested_jdk/bin/java -jar jtreg.jar -gui
> >> path_to_icedtea6/openjdk/hotspot/test
> >>
> >>
> >>
> >> Attachments in this mail:
> >>
> >> hg_export_openjdk7.diff - original export from OpenJDK7, the patch is
> >> based on this export
> >>
> >> 6853592-BadWindow-warning-fix.patch - the patch itself
> >>
> > 
> > This may be me being a little pedantic, but all other patches have file
> > names in all lower case. Could you please rename the patch to something
> > like 6853592-badwindow-warning-fix.patch when you add it to IcedTea6?
> 
> yes, of course
> 
> > 
> >> hg_export_icedtea6.diff - changes I would like to do in IcedTea
> >>
> > 
> > Can you please ensure that the additions to ChangeLog are based on a
> > line width of 80 chars?
> 
> ah sorry, I forgot to gq this line, will fix it.
> 
> > 
> > Everything else looks good to me.
> > 
> > Cheers,
> > Omair
> 

I approve this for 1.7, 1.8, 1.9 and HEAD with Omair's changes.

1.6 is a dead branch so don't apply it there.

6678385 is also in OpenJDK6 so please backport to OpenJDK6 too via jdk6-dev.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8