[RFC] icedtea-web: use url escaping consistently in filenames

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2010-10-19 16:13]:
> Hi,
> 
> The attached patch allows netx to work with jars with file names
> that need to be URL escaped (such as '[' and ']'). Netx consistently
> uses decoded URLs everywhere except in
> JNLPClassLoader.initializeResources().
> 
> File.toURI().toURL() encodes the filename as a URL, while
> File.toURL() does not encode the URL.
> 

To clarify.. URL location needs to stay decoded because it is used as a
key in a hashmap which is searched by other parts of the code using
decoded urls.

Change looks okay to me. Okay for commit.

Cheers,
Deepak

> Any comments or objections?
> 
> Cheers,
> Omair

> diff -r afdd3f284524 netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
> --- a/netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java	Mon Oct 18 21:29:09 2010 +0100
> +++ b/netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java	Tue Oct 19 15:53:30 2010 -0400
> @@ -424,7 +424,7 @@
>  
>                  for (JARDesc jarDesc: file.getResources().getJARs()) {
>                          try {
> -                                URL location = tracker.getCacheFile(jarDesc.getLocation()).toURI().toURL();
> +                                URL location = tracker.getCacheFile(jarDesc.getLocation()).toURL();
>                                  SecurityDesc jarSecurity = file.getSecurity();
>  
>                                  if (file instanceof PluginBridge) {