[icedtea-web] RFC: unify localization code

[Omair Majid]

Hi,

Netx contains a number of duplicate methods named "R" defined in various 
files that act as a wrapper for JNLPRuntime.getMessage(). The attached 
patch creates a new class Translate and moves all the "R" methods to it. 
This set of overloaded "R" methods is then statically imported anywhere 
that needs localized strings.

Changelog:
2010-10-25  Omair Majid  <omajid at redhat.com>
     * net/sourceforge/jnlp/ExtensionDesc.java: Import Translate.R
     and use that.
     * net/sourceforge/jnlp/JNLPFile.java: Import Translate.R.
     (R): Remove.
     * net/sourceforge/jnlp/JREDesc.java: Import Translate.R.
     (checkHeapSize): Use R instead of JNLPRuntime.getMessage.
     * net/sourceforge/jnlp/Launcher.java: Import Translate.R.
     (R): Remove.
     * net/sourceforge/jnlp/Parser.java: Import Translate.R
     (R(String)): Remove.
     (R(String,Object)): Remove.
     (R(String,Object,Object)): Remove.
     (R(String,Object,Object,Object)): Remove.
     * net/sourceforge/jnlp/cache/CacheEntry.java: Import
     Translate.R
     (CacheEntry): Use R instead of JNLPRuntime.getMessage.
     * net/sourceforge/jnlp/cache/CacheUtil.java: Import
     Translate.R
     (R(String)): Remove.
     (R(String,Object)): Remove.
     * net/sourceforge/jnlp/cache/DefaultDownloadIndicator.java:
     Import Translate.R and use that instead of
     JNLPRuntime.getMessage.
     * net/sourceforge/jnlp/runtime/Boot.java: Import Translate.R.
     (R(String)): Remove.
     (R(String, Object)): Remove.
     (run): Use R instead of JNLPRuntime.getMessage.
     * net/sourceforge/jnlp/runtime/JNLPClassLoader.java: Import
     Translate.R.
     (R): Remove.
     * net/sourceforge/jnlp/runtime/JNLPSecurityManager.java:
     Import Translate.R. Use it instead of JNLPRuntime.getMeesage.
     (R): Remove.
     * net/sourceforge/jnlp/security/AccessWarningPane.java:
     Import Translate.R.
     * net/sourceforge/jnlp/security/CertWarningPane.java:
     Likewise.
     * net/sourceforge/jnlp/security/HttpsCertVerifier.java:
     Import Translate.R.
     (R(String)): Remove.
     (R(String,String,String)): Remove.
     * net/sourceforge/jnlp/security/MoreInfoPane.java
     Import Translate.R.
     * net/sourceforge/jnlp/security/SecurityDialogPanel.java
     (R(String)): Remove.
     (R(String,Object)): Remove.
     * net/sourceforge/jnlp/services/ServiceUtil.java
     (R): Remove.
     * net/sourceforge/jnlp/services/SingleInstanceLock.java:
     Import Translate.R
     (R(String)): Remove.
     (R(String,Object)): Remove.
     * net/sourceforge/jnlp/tools/JarSigner.java: Import
     Translate.R.
     (R): Remove
     * net/sourceforge/jnlp/runtime/Translate.java: New file
     (R(String)): New method.
     (R(String,Object)): Likewise.
     (R(String,Object,Object)): Likewise.
     (R(String,Object,Object,Object)): Likewise.
     (R(String,Object[])): Likewise.

Any comments?

Thanks,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea-web-unify-localization-methods.patch
Type: text/x-patch
Size: 19138 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20101025/6e248139/icedtea-web-unify-localization-methods.patch