[icedtea-web] RFC: unify localization code

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2010-10-26 11:39]:
> On 10/25/2010 02:42 PM, Omair Majid wrote:
> >On 10/25/2010 02:24 PM, Deepak Bhole wrote:
> >>* Omair Majid<omajid at redhat.com> [2010-10-25 14:22]:
> >>>On 10/25/2010 02:20 PM, Omair Majid wrote:
> >>>>On 10/25/2010 01:22 PM, Deepak Bhole wrote:
> >>>>>* Omair Majid<omajid at redhat.com> [2010-10-25 12:54]:
> >>>>>>Hi,
> >>>>>>
> >>>>>>Netx contains a number of duplicate methods named "R" defined in
> >>>>>>various files that act as a wrapper for JNLPRuntime.getMessage().
> >>>>>>The attached patch creates a new class Translate and moves all the
> >>>>>>"R" methods to it. This set of overloaded "R" methods is then
> >>>>>>statically imported anywhere that needs localized strings.
> >>>>>>
> >>>>>
> >>>>>While it is being refactored, why not use varargs for R()?
> >>>>>
> >>>>
> >>>>Fixed.
> >>>
> >>>Grr.. Accceidentally sent without finishing email :(
> >>>
> >>>Here is the attachment.
> >>>
> >>
> >>Looks good. Okay for commit to HEAD.
> >>
> >>Deepak
> >>
> >
> >Thanks. Pushed to HEAD.
> >
> 
> I think I broke simple string translation :( New patch is attached.
> 
> ChangeLog:
> 2010-10-26  Omair Majid  <omajid at redhat.com>
> 
>     * netx/net/sourceforge/jnlp/runtime/Translator.java
>     (R(String)): New method.
> 
> Any comments?
> 

Looks fine to me. Ok for HEAD.

Deepak

> Thanks,
> Omair

> diff -r b1b876d99849 netx/net/sourceforge/jnlp/runtime/Translator.java
> --- a/netx/net/sourceforge/jnlp/runtime/Translator.java	Mon Oct 25 17:16:13 2010 -0400
> +++ b/netx/net/sourceforge/jnlp/runtime/Translator.java	Tue Oct 26 11:23:53 2010 -0400
> @@ -28,4 +28,13 @@
>          return JNLPRuntime.getMessage(message, params);
>      }
>  
> +    /**
> +     * Return a translated (localized) version of the message
> +     * @param message the message to translate
> +     * @return a string representing the localized message
> +     */
> +    public static String R(String message) {
> +        return JNLPRuntime.getMessage(message);
> +    }
> +
>  }