[icedtea-web] RFC: launch application that have a non-public main class

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2010-10-26 17:22]:
> Hi,
> 
> The attached patch bypasses checks imposed by the reflection API to
> ensure that netx is allowed to access the class it is trying to
> access. Generally, this makes complete sense. However, there are
> some applications (such as the Present/Future Value Calculator [1])
> that declare their main method in a non public class. Netx currently
> fails with an IllegalAccessException when it encounters this.
> 

Ugh. This shouldn't even be allowed :/

Anyway, we should follow the ri. Ok for HEAD.

Deepak

> ChangeLog
> 2010-10-26  Omair Majid  <omajid at redhat.com>
> 
>     * netx/net/sourceforge/jnlp/Launcher.java
>     (launchApplication): Mark main method as accessible before invoking
>     it.
> 
> Thanks,
> Omair
> 
> [1] http://www.arbores.ca/PresentFuture.jnlp

> diff -r b1b876d99849 netx/net/sourceforge/jnlp/Launcher.java
> --- a/netx/net/sourceforge/jnlp/Launcher.java   Mon Oct 25 17:16:13 2010 -0400
> +++ b/netx/net/sourceforge/jnlp/Launcher.java   Tue Oct 26 15:46:09 2010 -0400
> @@ -474,6 +475,7 @@
>                  splashScreen.dispose();
>              }
>  
> +            main.setAccessible(true);
>              main.invoke(null, new Object[] { args } );
>  
>              return app;