[icedtea-web] RFC: launch application that have a non-public main class

[Dr Andrew John Hughes]

On 16:04 Tue 26 Oct     , Omair Majid wrote:
> Hi,
> 
> The attached patch bypasses checks imposed by the reflection API to 
> ensure that netx is allowed to access the class it is trying to access. 
> Generally, this makes complete sense. However, there are some 
> applications (such as the Present/Future Value Calculator [1]) that 
> declare their main method in a non public class. Netx currently fails 
> with an IllegalAccessException when it encounters this.
> 
> ChangeLog
> 2010-10-26  Omair Majid  <omajid at redhat.com>
> 
>      * netx/net/sourceforge/jnlp/Launcher.java
>      (launchApplication): Mark main method as accessible before invoking
>      it.
> 
> Thanks,
> Omair
> 
> [1] http://www.arbores.ca/PresentFuture.jnlp

Looks good to me.

> diff -r b1b876d99849 netx/net/sourceforge/jnlp/Launcher.java
> --- a/netx/net/sourceforge/jnlp/Launcher.java   Mon Oct 25 17:16:13 2010 -0400
> +++ b/netx/net/sourceforge/jnlp/Launcher.java   Tue Oct 26 15:46:09 2010 -0400
> @@ -474,6 +475,7 @@
>                  splashScreen.dispose();
>              }
>  
> +            main.setAccessible(true);
>              main.invoke(null, new Object[] { args } );
>  
>              return app;


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8