[icedtea-web] RFC: add more JNLP spec numbers

[Dr Andrew John Hughes]

On 16:35 Tue 26 Oct     , Omair Majid wrote:
> Hi,
> 
> The attached patch adds more "supported" specification numbers to netx. 
> Secureftp2 [1] contains a JNLP file with a specification version 1.4 (I 
> think they might have confused the Java version with the JNLP 
> version...). In anticipation of the worst, I have also added 1.3 as a 
> supported version.
> 
> Personally I am starting to doubt the point of checking and failing if 
> the jnlp file specifies an unsupported version - I think netx should try 
> and run whatever it can instead of failing based on a (often wrong) version.
> 

I don't see the harm in not checking the version strictly.  I've always had
similar doubts about checking the Java specification level offered by a VM
(we have to patch this out to make gcj work in IcedTea).

> ChangeLog
> 2010-20-26  Omair Majid  <omajid at redhat.com>
> 
>      * netx/net/sourceforge/jnlp/Parser.java: Add 1.3 and 1.4 to
>      supportedVersions.
> 
> 
> Thanks,
> Omair
> 
> [1] http://www.glub.com/products/secureftp/jws/secureftp2.jnlp

> diff -r b1b876d99849 netx/net/sourceforge/jnlp/Parser.java
> --- a/netx/net/sourceforge/jnlp/Parser.java	Mon Oct 25 17:16:13 2010 -0400
> +++ b/netx/net/sourceforge/jnlp/Parser.java	Tue Oct 26 16:30:53 2010 -0400
> @@ -68,7 +68,7 @@
>  
>  
>      /** the supported JNLP file versions */
> -    private static Version supportedVersions = new Version("1.0 1.5 1.6 6.0");
> +    private static Version supportedVersions = new Version("1.0 1.3 1.4 1.5 1.6 6.0");
>  
>      // fix: some descriptors need to use the jnlp file at a later
>      // date and having file ref lets us pass it to their


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8