[icedtea-web] RFC: allow running make clean multiple times

[Deepak Bhole]

* Dr Andrew John Hughes <ahughes at redhat.com> [2010-10-28 18:39]:
> On 16:04 Thu 28 Oct     , Omair Majid wrote:
> > Hi,
> > 
> > Running make clean twice causes the second make clean to fail as it can 
> > not delete the non-existing directory $(PLUGIN_DIR)/launcher. The patch 
> > checks that the directory exists before trying to delete it. make clean 
> > will still fail if the directory exists and is not empty.
> > 
> > ChangeLog
> > 2010-10-28  Omair Majid  <omajid at redhat.com>
> > 
> >      * Makefile.am
> >      (clean-IcedTeaPlugin): Remove launcher directory only if it exists.
> > 
> > Thanks,
> > Omair
> 
> > diff -r 33f17695e034 Makefile.am
> > --- a/Makefile.am	Tue Oct 26 18:14:11 2010 -0400
> > +++ b/Makefile.am	Thu Oct 28 15:57:36 2010 -0400
> > @@ -190,7 +190,9 @@
> >  clean-IcedTeaPlugin:
> >  	rm -f $(PLUGIN_DIR)/launcher/*.o
> >  	rm -f $(PLUGIN_DIR)/launcher/pluginappletviewer
> > -	rmdir $(PLUGIN_DIR)/launcher
> > +	if [ -e $(PLUGIN_DIR)/launcher ]; then \
> > +		rmdir $(PLUGIN_DIR)/launcher ; \
> > +	fi
> >  	rm -f $(PLUGIN_DIR)/*.o
> >  	rm -f $(PLUGIN_DIR)/IcedTeaPlugin.so
> >  	if [ $(abs_top_srcdir) != $(abs_top_builddir) ]; then \
> 
> Yeah, sorry we need these checks here just as we do in IcedTea6.
> 
> The option suggested by Deepak sounds both non-standard and won't solve
> this problem (lack of existence not emptiness).

Doh! Sorry, I misread the man page (and clearly copied and pasted
without reading the switch name!). I thought it was "ignore if dir
doesn't exist". Sorry about that :/

Cheers,
Deepak

> -- 
> Andrew :)
> 
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> Support Free Java!
> Contribute to GNU Classpath and the OpenJDK
> http://www.gnu.org/software/classpath
> http://openjdk.java.net
> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8