[patch] add a man page for javaws

[Omair Majid]

Hi,

On 09/14/2010 07:02 AM, Dr Andrew John Hughes wrote:
> On 14:37 Thu 09 Sep     , Omair Majid wrote:
>> Hi,
>>
>> OpenJDK6 contains a man page for javaws, but it has two problems:
>>    - it not applicable to netx which has different quirks and options
>>    - openjdk's javaws man page is only "built" on a 32 bit arch.
>>
>> The attached patch adds a man page for javaws, which overwrites the one
>> from openjdk. This man page should be much more relevant to anyone using
>> IcedTea. Any comments or concerns?
>>
>> 2010-09-09  Omair Majid<omajid at redhat.com>
>>
>>       Add a new man page for netx's javaws.
>>       * Makefile.am
>>       (stamps/add-netx.stamp): Copy over the javaws man page into the
>>       build.
>>       (clean-add-netx): Remove the javaws man pages on clean.
>>       (stamps/add-netx-debug.stamp): Copy over the javaws man page.
>>       (clean-add-netx-debug): Remove the javaws man page.
>>       * netx/javaws.1: New man page for netx's javaws.
>>
>> Cheers,
>> Omair
>

> This has broken the build on toadeater:
>
> cp /notnfs/nighttester/icedtea6-target-testing/netx/javaws.1 /notnfs/nighttester/icedtea6-target-testing/openjdk.build/j2sdk-image/man/man1
> cp: cannot create regular file `/notnfs/nighttester/icedtea6-target-testing/openjdk.build/j2sdk-image/man/man1': No such file or directory
> make[1]: *** [stamps/add-netx.stamp] Error 1
> make[1]: Leaving directory `/notnfs/nighttester/icedtea6-target-testing'
>
> I think you need to add a check to make sure this directory exists (maybe it is not built if docs are disabled?)
>
> I also notice that you missed adding the logic to the ecj build.
>
> Thanks,

Ah, sorry about that. I looked into it and the build logic seems a 
little weird. Doing a 'make hotspot' causes netx/plugin to be built but 
not the rest of the jdk. The directories $(build)/jre/lib/$(arch) are 
created, so netx.jar and plugin.jar are copied into jre/lib 
successfully, but since the man directory is not, the copying of the man 
page fails.

The attached patch makes the copying of man pages conditional on 
ENABLE_DOCS as well as the man folder existing. I am not sure if this is 
the best solution though. Any thoughts?

As for ecj, I am slightly confused. I updated all the targets that 
create or remove netx.jar. Are netx/plugin even built with ecj?

Thanks,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea6-javaws-man-updated.patch
Type: text/x-patch
Size: 2947 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20100914/f3ca002e/icedtea6-javaws-man-updated.patch