Patch for regression test OnScreenRenderingResizeTest

Dr Andrew John Hughes ahughes at redhat.com
Mon Sep 20 10:53:36 PDT 2010


On 18:38 Mon 20 Sep     , Pavel Tisnovsky wrote:
> Dr Andrew John Hughes wrote:
> > On 16:33 Mon 20 Sep     , Pavel Tisnovsky wrote:
> >> Dr Andrew John Hughes wrote:
> >>> On 17:18 Fri 17 Sep     , Pavel Tisnovsky wrote:
> >>>> Hi,
> >>>>
> >>>> is it possible to add patch [1] for regression test
> >>>> OnScreenRenderingResizeTest.java to IcedTea6 HEAD?
> >>>>
> >>>> Changed test is already pushed to OpenJDK7 (bug ID#6984543) and I hope
> >>>> it will be possible to backport it to OpenJDK6 too.
> >>>>
> >>> I don't see this patch in the jdk7/jdk7/jdk repository.  Can you provide a link to the changeset?
> >> http://hg.openjdk.java.net/jdk7/tl/jdk/rev/441e86ab3233
> >>
> > 
> > Ok, please apply as described in the previous mail (below) by exporting the changeset.
> 
> will do
> 
> > Does this test fail on any of the release trees?
> 
> This test has never passed even on OpenJDK7 :-)
> It's been added to head on 2010-08-04 or day before and it's included in
> IcedTea6-1.9 (but not in previous trees).
> 

Ok, then please apply this fix to the 1.9 branch as well.

> > 
> >>> The backported patch should be an export of the commit i.e. with the bug ID and committer headers
> >>> and named patches/openjdk/6984543-onscreen_rendering_resize_test.patch.
> >>>
> >>>> Pavel
> >>>> --- openjdk/jdk/test/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest-old.java	2010-09-17 14:01:17.000000000 +0200
> >>>> +++ openjdk/jdk/test/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java	2010-09-17 13:20:00.000000000 +0200
> >>>> @@ -157,7 +157,7 @@
> >>>>              if (cnt == 90 && robot != null) {
> >>>>                  // area where we blitted to should be either white or green
> >>>>                  Point p = frame.getLocationOnScreen();
> >>>> -                p.move(in.left+10, in.top+10);
> >>>> +                p.translate(in.left+10, in.top+10);
> >>>>                  BufferedImage bi =
> >>>>                      robot.createScreenCapture(
> >>>>                          new Rectangle(p.x, p.y, IMAGE_W/2, IMAGE_H/2));
> >>>> @@ -166,7 +166,7 @@
> >>>>  
> >>>>                  // the are where we didn't render should stay white
> >>>>                  p = frame.getLocationOnScreen();
> >>>> -                p.move(in.left, in.top+IMAGE_H+5);
> >>>> +                p.translate(in.left, in.top+IMAGE_H+5);
> >>>>                  bi = robot.createScreenCapture(
> >>>>                      new Rectangle(p.x, p.y,
> >>>>                                    frame.getWidth()-in.left-in.right,
> >>>
> > 
> 
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the distro-pkg-dev mailing list