[RFC] Backport PR557 to stable branches

[Dr Andrew John Hughes]

On 17:26 Fri 17 Sep     , Deepak Bhole wrote:
> Hi,
> 
> PR557 affects all branches, and I think it should be backported to the
> stable supported ones (1.7, 1.8 and 1.9).
> 
> Patch is attached. Are there any objections? 
> 
> ChangeLog:
> 2010-09-17  Deepak Bhole <dbhole at redhat.com>
> 
>    PR557: Applet opens in a separate window if tab is closed when the applet
>    loads
>    * plugin/icedteanp/IcedTeaNPPlugin.cc 
>    (ITNP_Destroy): Send a destroy message to let Java side know that the
>    applet needs to be destroyed.
> 
> Please also note that for the branches, the above will not completely
> fix PR557 (there will still be a time window in which it can be
> triggered. But that window will be a much smaller one.). This is because
> the branches continue to remain affected by PR556 (race conditions
> during initialization). PR556 is fixed in HEAD and will eventually be
> backported to the branches.
> 

This one is approved for 1.7, 1.8 and 1.9.

What's the status of PR556?  What do you mean by 'eventually backported'?

> Cheers,
> Deepak

> # HG changeset patch
> # User Deepak Bhole <dbhole at redhat.com>
> # Date 1284757272 14400
> # Node ID f9af7b6a08ebd165a2df27af909a91718cfb9503
> # Parent  ddbf2447886c46c5db2d7c3e68205b4ae7884e21
> Fixed PR557 - Applet opens in a separate window if tab is closed when the
> applet loads
> 
> diff -r ddbf2447886c -r f9af7b6a08eb plugin/icedteanp/IcedTeaNPPlugin.cc
> --- a/plugin/icedteanp/IcedTeaNPPlugin.cc	Fri Sep 17 17:36:07 2010 +0100
> +++ b/plugin/icedteanp/IcedTeaNPPlugin.cc	Fri Sep 17 17:01:12 2010 -0400
> @@ -634,14 +634,21 @@
>  
>    ITNPPluginData* data = (ITNPPluginData*) instance->pdata;
>  
> +  int id = get_id_from_instance(instance);
> +
> +  // Let Java know that this applet needs to be destroyed
> +  gchar* msg = (gchar*) g_malloc(512*sizeof(gchar)); // 512 is more than enough. We need < 100
> +  g_sprintf(msg, "instance %d destroy", id);
> +  plugin_send_message_to_appletviewer(msg);
> +  g_free(msg);
> +  msg = NULL;
> +
>    if (data)
>      {
>        // Free plugin data.
>        plugin_data_destroy (instance);
>      }
>  
> -  int id = get_id_from_instance(instance);
> -
>    g_hash_table_remove(instance_to_id_map, instance);
>    g_hash_table_remove(id_to_instance_map, GINT_TO_POINTER(id));
>  


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8