/hg/icedtea6: Fixed PR557 - Applet opens in a separate window if...

[Andrew Su]

Hello,

I tested rapidly refreshing a web page that loads about 10 applets, and this does close the applets that pop-up, however sometimes there will still be applets hanging around (not all of them gets closed). At other times, there is a chance that the applet shows up blank on the website but will popup in a separate window.

--Andrew


----- dbhole at icedtea.classpath.org wrote:

> From: dbhole at icedtea.classpath.org
> To: distro-pkg-dev at openjdk.java.net
> Sent: Friday, September 17, 2010 5:01:07 PM GMT -05:00 US/Canada Eastern
> Subject: /hg/icedtea6: Fixed PR557 - Applet opens in a separate window if...
>
> changeset f9af7b6a08eb in /hg/icedtea6
> details:
> http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=f9af7b6a08eb
> author: Deepak Bhole <dbhole at redhat.com>
> date: Fri Sep 17 17:01:12 2010 -0400
> 
> 	Fixed PR557 - Applet opens in a separate window if tab is closed
> 	when the applet loads
> 
> 
> diffstat:
> 
> 3 files changed, 18 insertions(+), 2 deletions(-)
> ChangeLog                           |    8 ++++++++
> NEWS                                |    1 +
> plugin/icedteanp/IcedTeaNPPlugin.cc |   11 +++++++++--
> 
> diffs (52 lines):
> 
> diff -r ddbf2447886c -r f9af7b6a08eb ChangeLog
> --- a/ChangeLog	Fri Sep 17 17:36:07 2010 +0100
> +++ b/ChangeLog	Fri Sep 17 17:01:12 2010 -0400
> @@ -1,3 +1,11 @@ 2010-09-17  Andrew John Hughes  <ahughes
> +2010-09-17  Deepak Bhole <dbhole at redhat.com>
> +
> +	PR557: Applet opens in a separate window if tab is closed when the
> applet
> +	loads
> +	* plugin/icedteanp/IcedTeaNPPlugin.cc 
> +	(ITNP_Destroy): Send a destroy message to let Java side know that
> the
> +	applet needs to be destroyed.
> +
>  2010-09-17  Andrew John Hughes  <ahughes at redhat.com>
>  
>  	* Makefile.am:
> diff -r ddbf2447886c -r f9af7b6a08eb NEWS
> --- a/NEWS	Fri Sep 17 17:36:07 2010 +0100
> +++ b/NEWS	Fri Sep 17 17:01:12 2010 -0400
> @@ -20,6 +20,7 @@ New in release 1.10 (2010-XX-XX):
>    - A new man page for javaws.
>  * Plugin  
>    - PR556: Applet initialization code is prone to race conditions
> +  - PR557: Applet opens in a separate window if tab is closed when
> the applet loads
>  
>  New in release 1.9 (2010-09-07):
>  
> diff -r ddbf2447886c -r f9af7b6a08eb
> plugin/icedteanp/IcedTeaNPPlugin.cc
> --- a/plugin/icedteanp/IcedTeaNPPlugin.cc	Fri Sep 17 17:36:07 2010
> +0100
> +++ b/plugin/icedteanp/IcedTeaNPPlugin.cc	Fri Sep 17 17:01:12 2010
> -0400
> @@ -634,13 +634,20 @@ ITNP_Destroy (NPP instance, NPSavedData*
>  
>    ITNPPluginData* data = (ITNPPluginData*) instance->pdata;
>  
> +  int id = get_id_from_instance(instance);
> +
> +  // Let Java know that this applet needs to be destroyed
> +  gchar* msg = (gchar*) g_malloc(512*sizeof(gchar)); // 512 is more
> than enough. We need < 100
> +  g_sprintf(msg, "instance %d destroy", id);
> +  plugin_send_message_to_appletviewer(msg);
> +  g_free(msg);
> +  msg = NULL;
> +
>    if (data)
>      {
>        // Free plugin data.
>        plugin_data_destroy (instance);
>      }
> -
> -  int id = get_id_from_instance(instance);
>  
>    g_hash_table_remove(instance_to_id_map, instance);
>    g_hash_table_remove(id_to_instance_map, GINT_TO_POINTER(id));