[patch] new JTreg test for IcedTea6 & 7

[Dr Andrew John Hughes]

On 13:36 Wed 22 Sep     , Pavel Tisnovsky wrote:
> Dr Andrew John Hughes wrote:
> > On 16:01 Tue 21 Sep     , Pavel Tisnovsky wrote:
> >> Dr Andrew John Hughes wrote:
> >>> On 11:29 Tue 21 Sep     , Pavel Tisnovsky wrote:
> >>>> Hi all,
> >>>>
> >>>> is it possible to push new JTreg test to IcedTea6 HEAD and probably to 7
> >>>> too? This test check if JDK does not crash when window is quickly
> >>>> repeatedly resized.
> >>>>
> >>>> In fact it's a reproducer for this bug:
> >>>> https://bugzilla.redhat.com/show_bug.cgi?format=multiple&id=603962
> >>>>
> >>>> The test itself is based on Deepak's and Omair's code.
> >>>>
> >>>> Pavel
> >>>>
> >>> If this is pushed to 7, it should be pushed to the IcedTea forest
> >>> (http://hg.openjdk.java.net/icedtea/jdk7/jdk) not added as a patch.
> >>>
> >>> Have you sent this upstream?
> >> Not yet, as I was unable to find related bug in Oracle bug database.
> >>
> > 
> > Then just ask them to file one.
> > 
> > But in this case:
> > 
> > S6678385, RH551835: Fixes jvm crashes when window is resized.
> 
> Is the bug ID 6678385 really correct? It seems it is focused to another
> problem (StackOverflowError versus JDK crash).
> 

I don't follow; a StackOverflowError does cause a crash.

If you don't think it's appropriate, ask them for a bug ID.  Either way, it would
be good to get feedback from the Oracle developer teams on this.

> > 
> > is in the NEWS file so you should use 6678385.
> > 
> >>>> --- /dev/null	2010-06-29 11:10:08.737208357 +0200
> >>>> +++ openjdk/jdk/test/javax/swing/ResizeCrasher/ResizeCrasher.java	2010-09-17 14:40:51.000000000 +0200
> >>>> @@ -0,0 +1,105 @@
> >>>> +/*
> >>>> + * Copyright 2010 Red Hat, Inc. All Rights Reserved.
> >>>> + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> >>>> + *
> >>>> + * This code is free software; you can redistribute it and/or modify it
> >>>> + * under the terms of the GNU General Public License version 2 only, as
> >>>> + * published by the Free Software Foundation.
> >>>> + *
> >>>> + * This code is distributed in the hope that it will be useful, but WITHOUT
> >>>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> >>>> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
> >>>> + * version 2 for more details (a copy is included in the LICENSE file that
> >>>> + * accompanied this code).
> >>>> + *
> >>>> + * You should have received a copy of the GNU General Public License version
> >>>> + * 2 along with this work; if not, write to the Free Software Foundation,
> >>>> + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
> >>>> + */
> >>>> +
> >>>> +import java.awt.BorderLayout;
> >>>> +import java.awt.Container;
> >>>> +import java.awt.Dimension;
> >>>> +
> >>>> +import javax.swing.JButton;
> >>>> +import javax.swing.JFrame;
> >>>> +import javax.swing.JTextField;
> >>>> +import javax.swing.SwingUtilities;
> >>>> +import javax.swing.UIManager;
> >>>> +
> >>>> +/* @test
> >>>> + * @summary This test check if OpenJDK does not crash when window is repeatedly resized.
> >>>> + * bug #603962 in RH bugzilla (https://bugzilla.redhat.com/show_bug.cgi?format=multiple&id=603962)
> >>>> + * @author Deepak Bhole, Pavel Tisnovsky
> >>>> + * @run main ResizeCrasher
> >>>> + */
> >>>> +
> >>>> +public class ResizeCrasher {
> >>>> +    private static final Dimension FRAME_DIMENSION = new Dimension(100, 200);
> >>>> +
> >>>> +    // test duration is specified in milliseconds
> >>>> +    private static final int TEST_DURATION = 10000;
> >>>> +
> >>>> +    // some window managers print weird warnings when
> >>>> +    // window is too small
> >>>> +    private static final int MINIMAL_WINDOW_SIZE = 25;
> >>>> +
> >>>> +    static JFrame mainWindow;
> >>>> +
> >>>> +    ResizeCrasher() {
> >>>> +        mainWindow = new JFrame("Crashes on Resizing"); //$NON-NLS-1$
> >>>> +
> >>>> +        mainWindow.setSize(FRAME_DIMENSION);
> >>>> +        mainWindow.setResizable(true);
> >>>> +
> >>>> +        addControlsToContainer(mainWindow.getContentPane());
> >>>> +
> >>>> +        mainWindow.setVisible(true);
> >>>> +    }
> >>>> +
> >>>> +    private void addControlsToContainer(Container container) {
> >>>> +        JTextField aTextField = new JTextField("JTextField"); //$NON-NLS-1$
> >>>> +        aTextField.setPreferredSize(new Dimension(200,200));
> >>>> +        container.add(aTextField, BorderLayout.CENTER);
> >>>> +
> >>>> +        JButton aButton = new JButton("JButton"); //$NON-NLS-1$
> >>>> +        aButton.setPreferredSize(new Dimension(100, 200));
> >>>> +        container.add(aButton, BorderLayout.SOUTH);
> >>>> +    }
> >>>> +
> >>>> +    public static void main(String[] args) {
> >>>> +
> >>>> +        try {
> >>>> +            UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());
> >>>> +            // UIManager.setLookAndFeel(UIManager.getCrossPlatformLookAndFeelClassName());
> >>>> +        
> >>>> +            SwingUtilities.invokeAndWait(new Runnable() {
> >>>> +                public void run() {
> >>>> +                    new ResizeCrasher();
> >>>> +                }
> >>>> +            });
> >>>> +        } catch (Exception e) {
> >>>> +            System.out.println("Could not set look and feel"); //$NON-NLS-1$
> >>>> +        }
> >>>> +
> >>>> +        final java.util.Random r = new java.util.Random();
> >>>> +        long t1 = System.currentTimeMillis();
> >>>> +
> >>>> +        // run the test only for given time period
> >>>> +        while (System.currentTimeMillis() - t1 < TEST_DURATION) {
> >>>> +            try {
> >>>> +                SwingUtilities.invokeAndWait(new Runnable() {
> >>>> +                    public void run() {
> >>>> +                        mainWindow.setSize(r.nextInt(200) + MINIMAL_WINDOW_SIZE, r.nextInt(200) + MINIMAL_WINDOW_SIZE);
> >>>> +                    }
> >>>> +                });
> >>>> +            } catch (Exception e) {
> >>>> +                e.printStackTrace();
> >>>> +            }
> >>>> +        }
> >>>> +        if (mainWindow != null) {
> >>>> +            mainWindow.dispose();
> >>>> +        }
> >>>> +
> >>>> +    }
> >>>> +}
> >>>>
> >>>
> > 
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8