[RFC] [Plugin] Fixes 100% cpu load

[Andrew Haley]

On 09/28/2010 10:14 PM, Andrew Su wrote:
> Update:
> -Changed to use ConcurrentHashMap.
> -Used suggestion of putIfAbsent instead of locking.
> 
> Cheers,
> --Andrew
> 
> Attached:
> Modified version of file.
> Patch file.

One small thing: appLock is a collection of locks, so should be called
appLocks.

The code

  appLock.get(identifier).notifyAll();

is weird: isn't that lock already held?

The way locking is being done here makes me very nervous.  The locked
region is very long, and the interaction between threads and locks is
complex.

I wonder if the additional synchronization is patching around a design
problem.

Andrew.