[icedtea-web] RFC: add unit tests for the jnlp parser
Omair Majid
omajid at redhat.com
Fri Apr 1 14:54:32 PDT 2011
On 03/31/2011 04:56 PM, Dr Andrew John Hughes wrote:
> On 15:30 Thu 31 Mar , Omair Majid wrote:
>> On 03/31/2011 02:26 PM, Dr Andrew John Hughes wrote:
>>> On 13:40 Thu 31 Mar , Omair Majid wrote:
>>>> On 03/30/2011 08:21 PM, Dr Andrew John Hughes wrote:
>>>>>
>>>>> It does need documenting in README, but I'm happy for that to be a separate patch.
>>>>
>>>> Patch attached. Does that look okay?
>>>>
>>>
>>> It's a bit brief.
>>>
>>> * What about documenting the --with-rhino/junit options?
>>> * What about something specific about the JUnit tests?
>>
>> Okay, how about the new patch?
>>
> Still nothing on the JUnit stuff, which was the main reason I thought we were
> patching the docs. The custom output and the reasoning for it should be noted
> IMHO.
>
Ah, _now_ I get it. I thought by JUnit, you were referring to JUnit
itself, not our frontend/formatter for it.
I thought my documentation of that in tests/junit-runner/README was
sufficient. Anyway, I have updated the README for that too. Any other
suggestions?
Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: update-readme-03.patch
Type: text/x-patch
Size: 2360 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110401/bffd365a/update-readme-03.patch
More information about the distro-pkg-dev
mailing list