[RFC][Icedtea-web]: Changed how cache works.

[Omair Majid]

On 04/04/2011 05:45 PM, Andrew Su wrote:
>>> I think this patch would be easier to review if you split it into
>>> two patches - one to fix problems with files being overwritten,
>>> and another to enforce cache sizes.
> I've removed the section which will ensure the cache limit. Will post
> that later.
>

Thanks!

> +    /**
> +     * This will return a File pointing to the location of cache item.
> +     * @param urlPath Path of cache item within cache directory.
> +     * @return File if we have searched before, null otherwise.
> +     */
> +    private static File getCacheFileIfExist(File urlPath){


Instead of nitpicking, I am going to ask you to post some information 
about the files added/modified. I missed this during the original review 
(I suppose that might be a code smell and we need to do some 
refactoring), but now I see that this patch introduces and/or modifies a 
number of files: RecentlyUsed, per cache-entry directory, and possibly 
more metadata. Could you please describe what the overall design of this 
cache is? What data each file contains? And in what format?

I would love it if the response consists of patch with a new class per 
file/directory introduced/modified/repurposed and each class contains 
(as comments) the purpose and format :D

Cheers,
Omair