[icedtea-web] RFC: Make window close events use destroyApplet()

Deepak Bhole dbhole at redhat.com
Thu Apr 7 15:08:39 PDT 2011


* Denis Lila <dlila at redhat.com> [2011-04-07 17:59]:
> > destroyApplet() calls appletClose(), but is thread-safe and can be
> > called
> > multiple times safely unlike appletClose() which throws an NPE if
> > called again (depending on timing).
> 
> These NPE's have been pretty annoying.
> 

Yeah I agree. They don't seem to have any ill effects but I hate them
too.

> > I think this patch should go into 1.0 as well. OK for both?
> 
> I'm ok with that.
> 

Okay, thanks for reviewing! Change pushed.

Cheers,
Deepak

> Regards,
> Denis.
> 
> ----- Original Message -----
> > Hi,
> > 
> > Attached patch wires window close events to use destroyApplet() rather
> > than appletClose().
> > 
> 
> > 
> 
> > 
> > ChangeLog:
> > 2011-04-07 Deepak Bhole <dbhole at redhat.com>
> > 
> > * plugin/icedteanp/java/sun/applet/PluginAppletViewer.java
> > (constructor): Make window close event call destroy applet which can
> > be
> > safely called multiple times, unlike appletClose.
> > 
> > Cheers,
> > Deepak



More information about the distro-pkg-dev mailing list