[RFC][Icedtea-Web]: Ensure all ports entered are numeric values

[Dr Andrew John Hughes]

On 17:01 Tue 05 Apr     , Omair Majid wrote:
> On 04/05/2011 04:27 PM, Andrew Su wrote:

snip...

> > +            public void insertString(int offs, String str, AttributeSet a) throws BadLocationException {
> > +                if (str != null) {
> > +                    try {
> > +                        Integer.valueOf(str);

What is this line doing?  The return value is just thrown away.
If that's deliberate, at least document it.

> > +                        int val = Integer.valueOf(this.getText(0, this.getLength()) + str);
> > +                        if (val<  1 || val>  65535) { // Invalid port number if true
> > +                            throw new NumberFormatException("Invalid port number");
> > +                        }
> > +                        super.insertString(offs, str, a);
> > +                    } catch (Exception e) {
> > +                        JOptionPane.showMessageDialog(null, Translator.R("CPInvalidPort"), Translator.R("CPInvalidPortTitle")
> > +                                , JOptionPane.WARNING_MESSAGE);
> > +                    }
> > +                }
> > +                return;
> > +            }
> > +        };
> > +    }
> >   }
> > diff -r eea730466b87 netx/net/sourceforge/jnlp/resources/Messages.properties
> > --- a/netx/net/sourceforge/jnlp/resources/Messages.properties	Tue Apr 05 14:38:22 2011 -0400
> > +++ b/netx/net/sourceforge/jnlp/resources/Messages.properties	Tue Apr 05 16:26:59 2011 -0400
> > @@ -407,6 +407,8 @@
> >
> >   # Control Panel - Misc.
> >   CPJRESupport=IcedTea-Web currently does not support the use of multiple JREs.
> > +CPInvalidPort=Invalid port number given.\n[Valid port numbers are 1-65535]
> > +CPInvalidPortTitle=Error on input.
> >
> >   # command line control panel
> >   CLNoInfo=No information avaiable (is this a valid option?).
> 
> Everything else looks fine.
> 
> Cheers,
> Omair

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37