[icedtea-web] RFC: add unit tests for the jnlp parser

[Dr Andrew John Hughes]

On 10:36 Tue 05 Apr     , Omair Majid wrote:
> On 04/05/2011 08:12 AM, Andrew John Hughes wrote:
> > On Fri, Apr 01, 2011 at 05:54:32PM -0400, Omair Majid wrote:
> >> On 03/31/2011 04:56 PM, Dr Andrew John Hughes wrote:
> >>> On 15:30 Thu 31 Mar     , Omair Majid wrote:
> >>>> On 03/31/2011 02:26 PM, Dr Andrew John Hughes wrote:
> >>>>> On 13:40 Thu 31 Mar     , Omair Majid wrote:
> >>>>>> On 03/30/2011 08:21 PM, Dr Andrew John Hughes wrote:
> >>>>>>>
> >>>>>>> It does need documenting in README, but I'm happy for that to be a separate patch.
> >>>>>>
> >>>>>> Patch attached. Does that look okay?
> >>>>>>
> >>>>>
> >>>>> It's a bit brief.
> >>>>>
> >>>>> * What about documenting the --with-rhino/junit options?
> >>>>> * What about something specific about the JUnit tests?
> >>>>
> >>>> Okay, how about the new patch?
> >>>>
> >>> Still nothing on the JUnit stuff, which was the main reason I thought we were
> >>> patching the docs.  The custom output and the reasoning for it should be noted
> >>> IMHO.
> >>>
> >>
> >> Ah, _now_ I get it. I thought by JUnit, you were referring to JUnit
> >> itself, not our frontend/formatter for it.
> >>
> >
> > Sorry, should have been clearer.
> >
> 
> No worries.
> 
> >> I thought my documentation of that in tests/junit-runner/README was
> >> sufficient. Anyway, I have updated the README for that too. Any
> >> other suggestions?
> >
> > Ok, I'd forgotten about that file.  The changes aren't in the patch below, though...
> >
> 
> This bit below is what I was referring to:
> 
> >> +A custom JUnit ouput formatter is supplied. This makes the output of JUnit
> >> +tests match the output of other tests. A simple 'Passed:' or 'FAILED:' is
> >> +printed out, followed by<TestClass>.<testMethod>. This is also the format used
> >> +by JTreg.
> 

Ok, looks good.  Please commit.

> Cheers,
> Omair

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37