[RFC][plugin]: part 2 of changeset 191

[Dr Andrew John Hughes]

On 13:22 Tue 05 Apr     , Denis Lila wrote:
> Hi.
> 
> In changeset 191 I replaced PluginDebug.debug(String)
> by PluginDebug.debug(Object...). I also changed all
> uses of that method to use the varargs. However, it
> seems I forgot to change the uses in the netscape.javascript
> package. The attached patch does that.
> 

You should identify changes by the changeset id, as the revision
ID is not guaranteed to be applicable across multiple checkouts.

The change otherwise looks fine, but I think it's worth considering
a separate patch for this code which cleans up some of this output
particularly the 'GOT' and 'GOT IT' messages. 'retrieved' would be
better in both cases.

> Ok to push?
> 
> Thank you,
> Denis.

> diff -r 9c89214b7ef6 ChangeLog
> --- a/ChangeLog	Tue Apr 05 12:39:14 2011 -0400
> +++ b/ChangeLog	Tue Apr 05 13:21:02 2011 -0400
> @@ -1,3 +1,9 @@
> +2011-04-05  Denis Lila  <dlila at redhat.com>
> +
> +	* plugin/icedteanp/java/netscape/javascript/JSObject.java:
> +	Replaced every instance of PluginDebug.debug(a + b + c...)
> +	with PluginDebug.debug(a, b, c...).
> +
>  2011-04-05  Denis Lila  <dlila at redhat.com>
>  
>  	* netx/net/sourceforge/jnlp/cache/ResourceTracker.java:
> diff -r 9c89214b7ef6 plugin/icedteanp/java/netscape/javascript/JSObject.java
> --- a/plugin/icedteanp/java/netscape/javascript/JSObject.java	Tue Apr 05 12:39:14 2011 -0400
> +++ b/plugin/icedteanp/java/netscape/javascript/JSObject.java	Tue Apr 05 13:21:02 2011 -0400
> @@ -150,10 +150,10 @@
>       * Equivalent to "this.<i>name</i>" in JavaScript.
>       */
>      public Object getMember(String name) {
> -        PluginDebug.debug("JSObject.getMember " + name);
> +        PluginDebug.debug("JSObject.getMember ", name);
>  
>          Object o = PluginAppletViewer.getMember(internal, name);
> -        PluginDebug.debug("JSObject.getMember GOT " + o);
> +        PluginDebug.debug("JSObject.getMember GOT ", o);
>          return o;
>      }
>  
> @@ -163,7 +163,7 @@
>       */
>      //    public Object         getMember(int index) { return getSlot(index); }
>      public Object getSlot(int index) {
> -        PluginDebug.debug("JSObject.getSlot " + index);
> +        PluginDebug.debug("JSObject.getSlot ", index);
>  
>          return PluginAppletViewer.getSlot(internal, index);
>      }
> @@ -173,7 +173,7 @@
>       * Equivalent to "this.<i>name</i> = <i>value</i>" in JavaScript.
>       */
>      public void setMember(String name, Object value) {
> -        PluginDebug.debug("JSObject.setMember " + name + " " + value);
> +        PluginDebug.debug("JSObject.setMember ", name, " ", value);
>  
>          PluginAppletViewer.setMember(internal, name, value);
>      }
> @@ -186,7 +186,7 @@
>      //        setSlot(index, value);
>      //    }
>      public void setSlot(int index, Object value) {
> -        PluginDebug.debug("JSObject.setSlot " + index + " " + value);
> +        PluginDebug.debug("JSObject.setSlot ", index, " ", value);
>  
>          PluginAppletViewer.setSlot(internal, index, value);
>      }
> @@ -195,7 +195,7 @@
>       * Removes a named member of a JavaScript object.
>       */
>      public void removeMember(String name) {
> -        PluginDebug.debug("JSObject.removeMember " + name);
> +        PluginDebug.debug("JSObject.removeMember ", name);
>  
>          PluginAppletViewer.removeMember(internal, name);
>      }
> @@ -208,9 +208,9 @@
>          if (args == null)
>              args = new Object[0];
>  
> -        PluginDebug.debug("JSObject.call " + methodName);
> +        PluginDebug.debug("JSObject.call ", methodName);
>          for (int i = 0; i < args.length; i++)
> -            PluginDebug.debug(" " + args[i]);
> +            PluginDebug.debug(" ", args[i]);
>          PluginDebug.debug("");
>          return PluginAppletViewer.call(internal, methodName, args);
>      }
> @@ -221,7 +221,7 @@
>       * given by "this".
>       */
>      public Object eval(String s) {
> -        PluginDebug.debug("JSObject.eval " + s);
> +        PluginDebug.debug("JSObject.eval ", s);
>          return PluginAppletViewer.eval(internal, s);
>      }
>  
> @@ -246,7 +246,7 @@
>          long internal = 0;
>          internal = ((PluginAppletViewer)
>                      applet.getAppletContext()).getWindow();
> -        PluginDebug.debug("GOT IT: " + internal);
> +        PluginDebug.debug("GOT IT: ", internal);
>          return new JSObject(internal);
>      }
>  


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37